samba-bugs@samba.org
2006-Feb-22 23:31 UTC
DO NOT REPLY [Bug 3542] New: "rsync --list-only a b/" tries to create b
https://bugzilla.samba.org/show_bug.cgi?id=3542
Summary: "rsync --list-only a b/" tries to create b
Product: rsync
Version: 2.6.7
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: core
AssignedTo: wayned@samba.org
ReportedBy: hashproduct@verizon.net
QAContact: rsync-qa@samba.org
Rsync's --list-only option requires a destination, which is strange because
the
destination isn't used for anything. Nevertheless, in get_local_name, rsync
ensures that the destination is usable, which may involve trying to create the
destination as a directory. Luckily, if rsync tries to create the directory,
the attempt is caught in do_mkdir and an error message results, but rsync
really shouldn't care about the destination at all.
The patch I will soon attach causes get_local_name to return NULL immediately
if --list-only is given. However, there has to be a better way to ensure the
destination is not touched in this situation.
Separately, it would be an improvement if the destination argument could be
omitted when --list-only is given. (Until I read the man page, I kept trying
to run "rsync --list-only source/" and wondered why I got a usage
error.)
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Feb-22 23:32 UTC
DO NOT REPLY [Bug 3542] "rsync --list-only a b/" tries to create b
https://bugzilla.samba.org/show_bug.cgi?id=3542 ------- Comment #1 from hashproduct@verizon.net 2006-02-22 17:31 MST ------- Created an attachment (id=1753) --> (https://bugzilla.samba.org/attachment.cgi?id=1753&action=view) Makes get_local_name return NULL if --list-only is given -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-Feb-23 00:41 UTC
DO NOT REPLY [Bug 3542] "rsync --list-only a b/" tries to create b
https://bugzilla.samba.org/show_bug.cgi?id=3542
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Comment #2 from wayned@samba.org 2006-02-22 18:40 MST -------
Thanks! This is now fixed in CVS.
Also, rsync no longer returns a usage error when used with one local source arg
and no destination: this now implies the --list-only option, just like the
comparable situation with a remote source arg.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Reasonably Related Threads
- DO NOT REPLY [Bug 3549] New: rsync applies umask to some directories even when a default ACL takes effect
- get_local_name
- DO NOT REPLY [Bug 4080] New: rsync can't find basis dirs with -n and nonexistent destination
- DO NOT REPLY [Bug 3392] New: fuzzy misbehaving if source is a file
- DO NOT REPLY [Bug 3596] New: rsync fails to retouch S_IWUSR when transferring a single empty directory