samba-bugs@samba.org
2005-Feb-12 21:41 UTC
[Bug 1673] Verbose dry run doesn't report replacements of symlink with directory
https://bugzilla.samba.org/show_bug.cgi?id=1673 wayned@samba.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Additional Comments From wayned@samba.org 2005-02-12 14:37 ------- This is now fixed in the CVS version. It became very easy to fix after some recent changes I made provided the hierarchical depth value for each file, which means that anytime a directory is missing in --dry-run mode, we just need to ignore all items that are deeper in the list up to the next item that is less-than or equal-to the missing depth. Note that there is a potential for the incorrect output to occur when talking to an older rsync (prior to protocol 29). This is because the sort algorithm in earlier rsyncs might put an item from outside a directory's hierarchy in between the directory and its contents. To see this in action, update to the CVS version (also available in the latest "nightly" tar file), add a file named "projects.txt" in the "a" dir of the above test-case, and verify that the --dry-run output works properly. Then, repeat the test with the debug option "--protocol=28" and the items inside the projects dir will not be listed in --dry-run mode (because projects.txt sorted in between the dir and its contents). -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
Seemingly Similar Threads
- [Bug 1673] New: Verbose dry run doesn't report replacements of symlink with directory
- [Bug 1673] Verbose dry run doesn't report replacements of symlink with directory
- [Bug 1433] The --dry-run (-n) option doesn't report some directory changes
- DO NOT REPLY [Bug 4412] New: --dry-run output inaccurate due to implied symlink
- [Bug 10238] New: --dry-run does not change directory, causes --link-dest failure on symlinks