Logcheck devel - May 2004 - Re: [Logcheck-commits] CVS logcheck/debian

hmm you didn't test your code.


On Tue, 18 May 2004, CVS User eevans-guest wrote:
> --- /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2004/05/16 21:19:56
1.11
> +++ /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2004/05/18 19:52:39
1.12
  [..]
> +# Update the logcheck crontab to one of the alternate intervals
> +update_crontab()
> +{
> +    CRONTAB=/etc/cron.d/logcheck
> +    TMPCRON=`mktemp /var/tmp/logcheck-cron.XXXXXX`
> +    
> +    if [ -f $CRONTAB ] && [ "$1" == "daily" ]
; then
> +        sed -e
"s/^[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+\([[:space:]]\+.\+
\/usr\/sbin\/logcheck .\+$\)/2 0 * * *\1/g" $CRONTAB > $TMPCRON
> +	cp $TMPCRON $CRONTAB
> +	chown 644 $CRONTAB
          ^ ^ ???
below one more..
> +    fi
> +    
> +    if [ -f $CRONTAB ] && [ "$1" == "weekly" ]
; then
> +        sed -e
"s/^[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:digit:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+[[:space:]]\+[[:alnum:]*,-/]\+\([[:space:]]\+.\+
\/usr\/sbin\/logcheck .\+$\)/2 0 1 * *\1/g" $CRONTAB > $TMPCRON
> +	cp $TMPCRON $CRONTAB
> +	chown 644 $CRONTAB
> +    fi
> +    rm -f $TMPCRON
> +}
> +
>  case "$1" in
>      configure)
>  	# Remove old directory's
> @@ -57,6 +77,16 @@
>            chown logcheck /var/lock/logcheck &> /dev/null || true
>  	fi
>  
> --- /cvsroot/logcheck/logcheck/debian/logcheck.templates	2004/05/07
07:24:21	1.6
> +++ /cvsroot/logcheck/logcheck/debian/logcheck.templates	2004/05/18
19:52:39	1.7
please as alfie indicated on 5. may changes to logcheck.templates,
should be discussed before, didn't see your proposal?
they are really important for translators.
> @@ -20,3 +20,13 @@
>   directories.
>   .
>   Please see /usr/share/doc/logcheck for more details.
> +
> +Template: logcheck/cron
> +Type: select
> +Choices: weekly, daily, hourly
> +Default: hourly
> +_Description: How often should logcheck run to generate reports?
> + Logcheck is invoked by cron to periodically parse your log files and 
> + generate an email report. Hourly is the default and recommended 
> + interval for this, but you may also select from one of weekly or daily
> + as well.
i'm not shure if i like the last phrase? what about:
but you may also select daily or weekly as well.

a++ maks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040519/10299e8b/attachment.pgp

On Wed, May 19, 2004 at 10:02:42AM +0200, maks attems
wrote:
> > +Template: logcheck/cron
> > +Type: select
> > +Choices: weekly, daily, hourly
> > +Default: hourly
> > +_Description: How often should logcheck run to generate reports?
> > + Logcheck is invoked by cron to periodically parse your log files and
> > + generate an email report. Hourly is the default and recommended 
> > + interval for this, but you may also select from one of weekly or
daily
> > + as well.
> 
> i'm not shure if i like the last phrase? what about:
> but you may also select daily or weekly as well.
That part seems a bit redundant anyway as the user will be staring at those
choices allready.  I'd cut it off at the comma and maybe add "How often
should logcheck run?"

Good to see work on this, by the way.
-Todd

-- 
[   Todd J. Troxell                                         ,''`.
      Student, Debian GNU/Linux Developer, SysAdmin, Geek  : :' :
      http://debian.org || http://rapidpacket.com/~xtat    `. `' 
                                                             `-     ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040519/12dc4a38/attachment.pgp

On Wed, May 19, 2004 at 10:02:42AM +0200, maks attems muttered these
words:
> hmm you didn't test your code.
More accurate is that I did not test it well. :)
> > +	cp $TMPCRON $CRONTAB
> > +	chown 644 $CRONTAB
>           ^ ^ ???
> below one more..
A thinko, thanks for pointing them out.
> > --- /cvsroot/logcheck/logcheck/debian/logcheck.templates	2004/05/07
07:24:21	1.6
> > +++ /cvsroot/logcheck/logcheck/debian/logcheck.templates	2004/05/18
19:52:39	1.7
> 
> please as alfie indicated on 5. may changes to logcheck.templates,
> should be discussed before, didn't see your proposal?
> they are really important for translators.
I did read it, and I apologize if I failed to follow the agreed upon
protocol. I raised the issue of using debconf to prompt for the interval
on this list, and I always assume that any commit I make is subject to
review by the team and rolled back out if there is a consensus that it 
isn't right. What would constitute a proper proposal? Would it be better
to submit a diff here first?
> > +_Description: How often should logcheck run to generate reports?
> > + Logcheck is invoked by cron to periodically parse your log files and
> > + generate an email report. Hourly is the default and recommended 
> > + interval for this, but you may also select from one of weekly or
daily
> > + as well.
> 
> i'm not shure if i like the last phrase? what about:
> but you may also select daily or weekly as well.
That works. 

-- 
Eric Evans
eevans at sym-link.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :
http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040519/863cb384/attachment.pgp