Nut upsdev - Mar 2008 - [nut-commits] svn commit r1207 - in trunk: . include

Hi Charles,

while finishing the Testing release, I faced an autoreconf issue on
Testing, linked to the below change (to its non application on Testing
in fact):

include/Makefile.am:9: shell unset LANG && svnversion -n $(top_srcdir:
non-POSIX variable name
include/Makefile.am:9: (probably a GNU make extension)
include/Makefile.am:10: shell if test "$(SVNREV: non-POSIX variable name
include/Makefile.am:10: (probably a GNU make extension)

Obviously backporting the include/Makefile.am from trunk solves this.
So, was there any reason for not backporting this, or is it simply an oversight?

2007/12/31, Charles Lepple <clepple-guest at
alioth.debian.org>:
> Author: clepple-guest
>  Date: Mon Dec 31 16:32:58 2007
>  New Revision: 1207
>
>  Log:
>  Remove GNU Make extensions from rule to create nut_version.h, and handle
case
>  where svnversion does not exist.
>
>
>  Modified:
>    trunk/ChangeLog
>    trunk/include/Makefile.am
>
>  Modified: trunk/ChangeLog
> 
=============================================================================>
--- trunk/ChangeLog     (original)
>  +++ trunk/ChangeLog     Mon Dec 31 16:32:58 2007
>  @@ -1,3 +1,8 @@
>  +Mon Dec 31 16:30:50 GMT 2007 / Charles Lepple <clepple at
gmail.com>
>  +
>  + - include/Makefile.am: remove GNU Make extensions from rule to create
>  +   nut_version.h, and handle case where svnversion does not exist.
>  +
>   Mon Dec 31 15:54:23 UTC 2007 / Charles Lepple <clepple at
gmail.com>
>
>   - include/Makefile.am: fix failure to build after "make clean",
since
>
>  Modified: trunk/include/Makefile.am
>  ...
Arnaud
-- 
Linux / Unix Expert R&D - MGE Office Protection Systems -
http://www.mgeops.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
Free Software Developer - http://arnaud.quette.free.fr/

On Thu, Mar 27, 2008 at 7:40 AM, Arnaud Quette <aquette.dev at gmail.com>
wrote:
>  Obviously backporting the include/Makefile.am from trunk solves this.
>  So, was there any reason for not backporting this, or is it simply an
oversight?
Oversight. I haven't had the time to keep track of which changesets
have made it back to the Testing branch, sorry.

-- 
- Charles Lepple