Arjen de Korte
2007-Sep-03 19:20 UTC
[Nut-upsdev] Converting megatec_usb.c -> serial_usb.c
Folks, I think the present megatec_usb.c deserves to be renamed to serial_usb.c. I think it potentially could serve many more UPS'es with built-in USB-to-serial converters, not limited to the megatec_usb driver (although that was the first one to use this). I also think a more layered approach would be nice, in the same fashion as the usbhid-ups driver with subdrivers. Which would mean that we would split-off the lowlevel stuff (agiler, krauler) in separate source files and keep the remainder in serial_usb.c. Ultimately, the goal would be to bundle everything in a library that could be linked in by devices that have this kind of interface. Any thoughts/objections from making this split? Best regards, Arjen
Alexander I. Gordeev
2007-Sep-03 21:03 UTC
[Nut-upsdev] Converting megatec_usb.c -> serial_usb.c
On Mon, 03 Sep 2007 23:20:55 +0400, Arjen de Korte <nut+devel at de-korte.org> wrote:> Folks, > > I think the present megatec_usb.c deserves to be renamed to > serial_usb.c. I think it potentially could serve many more UPS'es with > built-in USB-to-serial converters, not limited to the megatec_usb driver > (although that was the first one to use this). I also think a more > layered approach would be nice, in the same fashion as the usbhid-ups > driver with subdrivers. Which would mean that we would split-off the > lowlevel stuff (agiler, krauler) in separate source files and keep the > remainder in serial_usb.c. Ultimately, the goal would be to bundle > everything in a library that could be linked in by devices that have > this kind of interface. Any thoughts/objections from making this split? > > Best regards, Arjen >No objections. However it is not clear to me that some driver can benefit from these serial-over-usb hacks. -- Alexander