Michael,
But really I see the code is commented, not the question - what was the
reason, will it work properly and as designed or breaks something else?
This is from the latest driver code
#if 0
skb->protocol = hdlc_type_trans(skb,
&ms->hdlcnetdev->netdev.netdev);
#else
skb->protocol = htons (ETH_P_HDLC);
#endif
And I see that maintainer has added already this and specially commented
out over the preprocessor.
Michael A Rowley wrote:
> Hello,
>
> I contacted Krzysztof Halasa, the maintainer of the current sethdlc
> code. This is the response he gave me.
>
> Of course, I have this working now. Still some minor configuration to
> do, but It does work, and the connections to the internet are _much_
> faster than when I went through the adtran... I would highly
> recommend to anyone with a fractionated T1, with data and voice
> channels to set up HDLC and not mess with the T1 router cost and
> trouble...
>
> M.
>
> Begin forwarded message:
>
>>
>>> but I am hoping to get hdlc working on
>>> linux kernel 2.4.26 with a digium T100P card from www.digium.com.
>>> Digium has built HDLC into the driver, and there are reports of
people
>>> getting it working, but only with kernel 2.4.22 and below... I am
>>> curious if you have had any success getting hdlc working on kernel
>>> 2.4.26, or 2.6.x versions, or if you can supply any guidance.
>>
>>
>> The generic HDLC works fine with 2.4.26 and 2.6.6 kernels (well,
>> 2.6.6s have some not very serious problems for which a fix is being
>> merged).
>>
>> The problem with Digium cards is they haven't been upgraded to
>> 2.4.26 kernels (the generic HDLC interface has changed a bit in
>> IIRC 2.4.23 and, while drivers in the official kernel have been
>> upgraded by the kernel team at the same time, it wasn't possible
>> with external drivers).
>>
>> For this kernel change (2.4.22->2.4.26) it might be sufficient to
>> find and change line(s) looking like this one:
>> skb->protocol = htons(ETH_P_HDLC);
>> into:
>> skb->protocol = hdlc_type_trans(skb, dev);
>>
>> It depends on the hardware driver, though.
>> --
>> Krzysztof Halasa, B*FH
>>