openssh unix dev - Sep 2003 - bsd-cray.c r.1.12: multiple syntax errors

There appears to be multiple errors in release 1.12 of bsd-cray.c as released
with 3.7.1p1:

1) line 62: missing #include "defines.h" in front of #include
"log.h", causing
compiler errors due to undefined cpp macro __attribute__(x).

2) line 185: declaration ``ia_user_t usent'' is not terminated with a
semicolon.

3) line 469: while loop ``while (valid_acct == -1) {'' ends in ``} else
{'' at
line 533. This else statement should probably match the if statement beginning
at line 467.

In addition there is probably an error in the ``switch (acct_name[0])
{''
``default'' tag at line 502: there is a ``break'' at line 509,
inside an if
statement, but no break to logically end the default tag.

Best Regards --J?rn Amundsen

yes, thanks.  i'm working on them.  there seem to be other problems too.
what arch are you working on?

Jxrn Aslak Amundsen wrote:
> There appears to be multiple errors in release 1.12 of bsd-cray.c as
released
> with 3.7.1p1:
> 
> 1) line 62: missing #include "defines.h" in front of #include
"log.h", causing
> compiler errors due to undefined cpp macro __attribute__(x).
> 
> 2) line 185: declaration ``ia_user_t usent'' is not terminated with
a
> semicolon.
> 
> 3) line 469: while loop ``while (valid_acct == -1) {'' ends in ``}
else {'' at
> line 533. This else statement should probably match the if statement
beginning
> at line 467.
> 
> In addition there is probably an error in the ``switch (acct_name[0])
{''
> ``default'' tag at line 502: there is a ``break'' at line
509, inside an if
> statement, but no break to logically end the default tag.
> 
> Best Regards --Jxrn Amundsen
> 
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev at mindrot.org
> http://www.mindrot.org/mailman/listinfo/openssh-unix-dev
> 

-- 
wendy palm
Cray Open Software Development, Cray Inc.
wendyp at cray.com, 651-605-9154