zfs crypto discuss - Apr 2008 - [Bug 1114] New: lack of error messages for ''zfs create ..'' when keysource file couldn''t be converted to a key

http://defect.opensolaris.org/bz/show_bug.cgi?id=1114

           Summary: lack of error messages for ''zfs create ..''
when
                    keysource file couldn''t be converted to a key
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Severity: minor
          Priority: P3
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


Test cases:
# zfs create -o encryption=on -o keyscope=dataset -o 
keysource=hex,file://$RAW_KEY_FILE tank/fs_1
# echo $?
1
( $RAW_KEY_FILE isn''t a valid hex key file.)

# zfs create -o encryption=on -o keyscope=dataset -o 
keysource=raw,file://$HEX_KEY_FILE tank/fs_2
# echo $?
1
( $HEX_KEY_FILE isn''t a valid raw key file.)

# zfs create -o encryption=on -o keyscope=dataset -o 
keysource=passphrase,file://$BLANKFILE tank/fs_3
# echo $?
1
( $BLANK_FILE is a blank file.)

Currently these commands fail without any error message. There should be error
indication like:
the file can''t be converted to a key.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1114


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1114


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ACCEPTED




--- Comment #1 from ajscarp at yahoo.com  2008-04-11 14:27:40 ---
I was able to reproduce this in the 2008-4-10 build, but I am unable to
reproduce it in my current code..  I don''t see any significant changes
between
the two code bases that should cause the failure.

I''m going to mark it as accepted, as it clearly is a bug in the
official build.
 Before the next build if I haven''t found any cause or fix,
I''ll assume it''s
fixed in the source..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1114





--- Comment #2 from ajscarp at yahoo.com  2008-04-11 14:29:44 ---
bash-3.2# export FILE=/home/izick/key2
bash-3.2# zfs create -o keyscope=dataset -o keysource=passphrase,file://$FILE -
o encryption=on tank/enc3
DEBUG: crypt = 0
DEBUG: keyscope = 0
DEBUG: keysource="passphrase,file:///home/izick/key2"
salt==0
salt==7010854228241457383
outkey (950104)=5ff5adf8317beed4b255246b8d545a27ea798ba2f4fb50299eec537e15e4
zic_key (950104)
bash-3.2# echo $?
0


It worked both in debug and non-debug on my new bits

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1114


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |CLOSED
         Resolution|                            |FIXINSOURCE




--- Comment #3 from ajscarp at yahoo.com  2008-04-18 11:38:57 ---
Will classify this as one of the changes that missed 2008-4-10 build.. If it
still exists after the next build, please reopen..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.