zfs crypto discuss - Apr 2008 - [Bug 1113] New: ''zfs create -o encryption=on -o keysource=raw, -o keyscope= dataset ..'' should fail

http://defect.opensolaris.org/bz/show_bug.cgi?id=1113

           Summary: ''zfs create -o encryption=on -o keysource=raw, -o
                    keyscope=dataset ..'' should fail
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


keysource=raw, is invalid, this subcomman should fail. Currently it
doesn''t
fail and create a dataset.

# zpool create tank /export/home/testfile
# zfs create -o encryption=on -o keysource=raw, -o keyscope=dataset tank/fs_1
# zfs list
NAME        USED  AVAIL  REFER  MOUNTPOINT
tank        140K   984M    18K  /tank
tank/fs_1    18K   984M    18K  /tank/fs_1
# zfs get all tank/fs_1
..
tank/fs_1  encryption       on                     local
tank/fs_1  keysource        raw,                   local
tank/fs_1  keyscope         dataset                local
tank/fs_1  keystatus        available              -

How could the encrypted dataset is created without a keysource?

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1113





--- Comment #1 from Grace <hua.tang at sun.com>  2008-04-11 05:27:07 ---
It should also fail with keysource=hex, instead of prompting enter key.

# zfs create -o encryption=on -o keysource=hex, -o keyscope=dataset tank/fs_2
Enter hexadecmial key for ''tank/fs_2'':
Enter again:
# echo $?
0
# zfs list
NAME        USED  AVAIL  REFER  MOUNTPOINT
tank        175K   984M    19K  /tank
tank/fs_1    18K   984M    18K  /tank/fs_1
tank/fs_2    18K   984M    18K  /tank/fs_2

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1113





--- Comment #2 from Grace <hua.tang at sun.com>  2008-04-11 05:32:44 ---
the same issue with keysource=passphrase,

# zfs create -o encryption=on -o keysource=passphrase, -o keyscope=dataset
tank/fs_3
Enter passphrase for ''tank/fs_3'':
Enter again:
# zfs list
tank/fs_3           18K   984M    18K  /tank/fs_3

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1113


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1113


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ACCEPTED




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1113


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |CLOSED
         Resolution|                            |FIXINSOURCE




--- Comment #3 from ajscarp at yahoo.com  2008-04-18 11:37:35 ---
error is length checking during strcmp of "prompt" causes to length of
0 to
return a KEY_LOCATOR_PROMPT value instead of a failure..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.