zfs crypto discuss - Apr 2008 - [Bug 969] New: zpool key -u panic''s

http://defect.opensolaris.org/bz/show_bug.cgi?id=969

           Summary: zpool key -u panic''s
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: ACCEPTED
          Severity: critical
          Priority: P2
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: darrenm at opensolaris.org
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


Locking issues with the spa key cause us to attempt to unload and free the key
when it was in use.

While testing the fix for this I discovered that we need to remove all the
unwrapped dsl keys.  Now that we no longer store the unwrapped dsl key in
dsl_dataset_t we need to do this remove explicitly.  The upside is this makes
everything a bit more robust.

To do this easily we use an avl_tree per keyscope type in the spa_keystore. 
That way we can walk the avl_tree for keyscope=pool when we do a ''zpool
key
-u''.

If we don''t do this then unloading the key has no impact for any
dataset that
has ever been read from or written to while the pool key was loaded.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=969





--- Comment #1 from Grace <hua.tang at sun.com>  2008-04-06 22:45:00 ---
Is this the same panic I saw today?
What''s more bad, I couldn''t recover my test machine. I
don''t want to
re-install, is there any workarounds?

panic[cpu0]/thread=ffffff015e5c5060: assertion failed: key->zk_refcnt == 0
(0x1
== 0x0), file: ../../common/fs/zfs/zio_crypt.c, line: 81

ffffff00052cdab0 genunix:assfail3+b9 ()
ffffff00052cdae0 zfs:zio_crypt_key_free+a1 ()
ffffff00052cdb30 zfs:spa_keystore_fini+c4 ()
ffffff00052cdb70 zfs:spa_unload+60 ()
ffffff00052cdbd0 zfs:spa_export_common+1ba ()
ffffff00052cdbf0 zfs:spa_export+1d ()
ffffff00052cdc20 zfs:zfs_ioc_pool_export+21 ()
ffffff00052cdca0 zfs:zfsdev_ioctl+162 ()
ffffff00052cdce0 genunix:cdev_ioctl+48 ()
ffffff00052cdd20 specfs:spec_ioctl+86 ()
ffffff00052cdda0 genunix:fop_ioctl+7b ()
ffffff00052cdeb0 genunix:ioctl+174 ()
ffffff00052cdf00 unix:brand_sys_syscall32+292 ()

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=969


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |CLOSED
         Resolution|                            |WORKSFORME




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-02 09:02:37 ---
Not reproducable:

braveheart# zpool key -u t
braveheart# zpool status
  pool: t
 state: ONLINE
   key: unavailable
 scrub: none requested
config:

        NAME          STATE     READ WRITE CKSUM
        t             ONLINE       0     0     0
          /export/t1  ONLINE       0     0     0
          /export/t2  ONLINE       0     0     0

errors: No known data errors
braveheart# zpool key -l t

braveheart# zpool status  
  pool: t
 state: ONLINE
   key: available
 scrub: none requested
config:

        NAME          STATE     READ WRITE CKSUM
        t             ONLINE       0     0     0
          /export/t1  ONLINE       0     0     0
          /export/t2  ONLINE       0     0     0

errors: No known data errors

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.