thr3ads.net - zfs crypto discuss - [Bug 964] New: panic: change key from keyscope dataset to pool [Apr 2008]

If this information is useful, please help other people find it:
Share via:

bugzilla-daemon at defect.opensolaris.org

2008-Apr-03 03:22 UTC

[Bug 964] New: panic: change key from keyscope dataset to pool

http://defect.opensolaris.org/bz/show_bug.cgi?id=964

           Summary: panic: change key from keyscope dataset to pool
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: ajscarp at yahoo.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


This probably needs key change for pools to work to be functional..nevertheless
it''s a test case..

After fixing 943 (zfs key -c, out of memory) and fixing a problem where
changing the keysource still asked for key data, i got a panic on the below...

tank/enc  keysource        passphrase,prompt      local
tank/enc  keyscope         dataset                local

bash-3.2# zfs key -c -o keyscope=pool tank/enc
salt= 0
keydatakeysourcedataset name=tank/enc

panic[cpu0]/thread=2a10092dca0: BAD TRAP: type=31 rp=2a10092d200 addr=0
mmu_fsr=0 occurred in module "zfs" due to a NULL pointer dereference

sched: trap type = 0x31
pid=0, pc=0x7b336550, sp=0x2a10092caa1, tstate=0x4480001607, context=0x0
g1-g7: 6001141a030, 400, 6001141a000, 200, 200, 50c, 2a10092dca0

000002a10092cf20 unix:die+80 (10ff800, 2a10092d200, 0, 0, 180e000, 1)
000002a10092d000 unix:trap+b30 (2a10092d200, c0580000, 31, 1, 1c00, 5)
000002a10092d150 unix:ktl0+48 (200, fd, e, 38, 3c00, ffffffffaaaaaaab)
000002a10092d2a0 55555400 (8, 0, 9, e, 15, 26a)
000002a10092d350 zfs:zap_leaf_array_create+b8 (600105e67c0, 0, 8, 1, 38, fb)
000002a10092d410 zfs:zap_entry_update+f8 (30c30c00, 12, 12, 0, 0, 8)
000002a10092d4c0 zfs:fzap_update+140 (600105261c0, 7b380800, 1, 0, 60010309c40,
0)
000002a10092d5b0 zfs:zap_update+90 (0, 20, 7b385a58, 8, 1, 0)
000002a10092d680 zfs:dsl_prop_set_sync+e4 (60010e4fa00, 2a10054f688,
6001121f890, 60010309c40, 20, 600106c8940)
000002a10092d770 zfs:dsl_sync_task_group_sync+11c (60011325198, 60010309c40,
7b319200, 60010463a50, 1, 0)
000002a10092d830 zfs:dsl_pool_sync+ec (600106c8940, 4ccd, 60010694800,
7b37af98, 60010309c40, 60010694830)
000002a10092d8e0 zfs:spa_sync+200 (6001012ad80, 4ccd, 0, 7b37adf8, 6001012aed0,
7b37af98)
000002a10092d9b0 zfs:txg_sync_thread+190 (600106c8940, 4ccd, 7b36ccd4,
7b37e038, 700b49b4, 2a10092da70)


This then causes a really bad scenario where you can''t boot the machine
and
even after doing a ''zpool destroy tank'' in single user mode,
it still panics..
I''m now having to reinstall the BE.. :)

NIS domain name is mpklab.sfbay.sun.com
Reading ZFS config: -
panic[cpu0]/thread=3000a7e4ba0: assertion failed: za.za_integer_length == 8
(0x4 == 0x8), file: ../../common/fs/zfs/dsl_prop.c, line: 512

000002a1006d33a0 genunix:assfail3+98 (7b37a000, 4, 7b379e08, 8, 7b379d60, 200)
000002a1006d3460 zfs:dsl_prop_get_all+224 (0, 2a1006d3810, 0, 2a1006d3530,
2a1006d3518, 2a1006d3630)
000002a1006d3760 zfs:zfs_ioc_objset_stats+44 (3000d2a2000, 0, aca48, 0,
3000d2a2000, 0)
000002a1006d3820 zfs:zfsdev_ioctl+1c4 (7b355b28, 700b5a60, ffbfc950, 1000,
60010003520, 3000d2a2000)

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-Apr-03 04:57 UTC

head link

[Bug 964] panic: change key from keyscope dataset to pool

http://defect.opensolaris.org/bz/show_bug.cgi?id=964





--- Comment #1 from ajscarp at yahoo.com  2008-04-02 21:57:56 ---
way to recover BE:

go single user, destroy pool, create a new pool, svcadm enable multi-user

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-Apr-09 15:55 UTC

head link

[Bug 964] panic: change key from keyscope dataset to pool

http://defect.opensolaris.org/bz/show_bug.cgi?id=964


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CAUSEKNOWN




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-04-09 08:55:54 ---
no longer panics but keyscope is left as keyscope=dataset.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-May-02 15:59 UTC

head link

[Bug 964] panic: change key from keyscope dataset to pool

http://defect.opensolaris.org/bz/show_bug.cgi?id=964


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com




--- Comment #3 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-02 08:59:25 ---
braveheart# zfs key -c -o keyscope=dataset t/4
salt= 0
keyscope= 0
keydatalen=0
keydatakeysourcedataset name=t/4
Key change error: Invalid argument


keyscope of 0 is ZFS_KEYSCOPE_INHERIT which is not what was specified on the
CLI.

So the kernel will be expecting keydata, because it doesn''t think we
are
chaning keyscope type, and there isn''t any so we get EINVAL.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-May-02 16:00 UTC

head link

[Bug 964] ''zfs key -c -o keyscope=pool'' EINVAL

http://defect.opensolaris.org/bz/show_bug.cgi?id=964


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|panic: change key from      |''zfs key -c -o
                   |keyscope dataset to pool    |keyscope=pool'' EINVAL
                 CC|                            |darrenm at opensolaris.org




--- Comment #4 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-02 09:00:48 ---
cut & paste the wrong test case but the rest of the info is correct:

braveheart# zfs get keyscope t/4
NAME  PROPERTY  VALUE     SOURCE
t/4   keyscope  dataset   local
braveheart# zfs key -c -o keyscope=pool t/4   
salt= 0
keyscope= 0
keydatalen=0
keydatakeysourcedataset name=t/4
Key change error: Invalid argument

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-May-07 16:07 UTC

head link

[Bug 964] ''zfs key -c -o keyscope=pool'' EINVAL

http://defect.opensolaris.org/bz/show_bug.cgi?id=964


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1403




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-May-15 05:00 UTC

head link

[Bug 964] ''zfs key -c -o keyscope=pool'' returns a blank keyscope property

http://defect.opensolaris.org/bz/show_bug.cgi?id=964


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|''zfs key -c -o              |''zfs key -c
-o
                   |keyscope=pool'' EINVAL      
|keyscope=pool'' returns a
                   |                            |blank keyscope property
             Status|CAUSEKNOWN                  |FIXINPROGRESS




--- Comment #5 from ajscarp at yahoo.com  2008-05-14 22:00:29 ---
zfs key -c is fixed in that it is not returning EINVAL.  The keysource is being
defined properly in the zic_ioc_crypt, and the ioctl is returning a success,
but the keyscope property is blank.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzilla-daemon at defect.opensolaris.org

2008-May-15 05:04 UTC

head link

[Bug 964] ''zfs key -c -o keyscope=pool'' EINVAL

http://defect.opensolaris.org/bz/show_bug.cgi?id=964


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|''zfs key -c -o              |''zfs key -c
-o
                   |keyscope=pool'' returns a   
|keyscope=pool'' EINVAL
                   |blank keyscope property     |
             Status|FIXINPROGRESS               |RESOLVED
         Resolution|                            |FIXINSOURCE




--- Comment #6 from ajscarp at yahoo.com  2008-05-14 22:04:39 ---
Since pool key change is not in the gate yet, zfs key -c can''t
complete.. So
this should be listed as resolved..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

zfs crypto discuss - Apr 2008 - [Bug 964] New: panic: change key from keyscope dataset to pool

[Bug 964] New: panic: change key from keyscope dataset to pool

[Bug 964] panic: change key from keyscope dataset to pool

[Bug 964] panic: change key from keyscope dataset to pool

[Bug 964] panic: change key from keyscope dataset to pool

[Bug 964] ''zfs key -c -o keyscope=pool'' EINVAL

[Bug 964] ''zfs key -c -o keyscope=pool'' EINVAL

[Bug 964] ''zfs key -c -o keyscope=pool'' returns a blank keyscope property

[Bug 964] ''zfs key -c -o keyscope=pool'' EINVAL