zfs crypto discuss - Mar 2008 - [Bug 904] New: dataset load may return cannot open ''HZ=100'': invalid dataset name

http://defect.opensolaris.org/bz/show_bug.cgi?id=904

           Summary: dataset load may return cannot open
''HZ=100'': invalid
                    dataset name
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: ajscarp at yahoo.com
        ReportedBy: ajscarp at yahoo.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


# zfs key -l tank/blah
Enter passphrase for ''tank/crap'': 
cannot open ''HZ=100'': invalid dataset name


The fact the dataset still is unavailable is a different but..

The cannot open "HZ=100" is because zfs_do_key''s load code
path calls
share_mount() after the key is loaded..  The share_mount function is not
designed to be called in this manner as it uses getopt..

Removing share_mount() to get rid of the error message is easy.. But the larger
question is if removing, will the newly loaded (keystatus=available) dataset to
be shared or not.. Does a call to share_mount_one() need to be called in its
place?  If it does, is there some policy we have to look at in case the dataset
is not supposed to be shared and what type of sharing..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=904


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CAUSEKNOWN




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=904


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CAUSEKNOWN                  |FIXINPROGRESS




--- Comment #1 from ajscarp at yahoo.com  2008-03-29 10:55:20 ---
I believe putting zfs_mount() and zfs_share() inside the
libzfs_crypto:zfs_load_key(), should suffice.

This will mount & share the particular datasets with their predefined
settings.. However this will not allow Temporary Mount Point Properties
(zfs(1m)).   Allowing such things would require "zfs key -l" to accept
"-o
<options>", which it does not today.. Given the priority list for
completion of
phase 1, that might not be high enough.. One can remount to the specific
options if need be..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=904


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darrenm at opensolaris.org
         AssignedTo|ajscarp at yahoo.com           |darrenm at opensolaris.org
             Status|FIXINPROGRESS               |FIXUNDERSTOOD




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-03-31 02:08:54 ---
I have a fix for this already in my workspace that uses the share_mount_one()
method of fixing this.

Putting the call to zfs_mount() and zfs_share() into zfs_load_key() is another
possible alternative.  We should check with our non ON API consumers of
zfs_load_key() if that is they way they would prefer it to be or if they would
rather explicitly mount/share themselves.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=904


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=904


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|FIXUNDERSTOOD               |CLOSED
         Resolution|                            |FIXED




--- Comment #3 from ajscarp at yahoo.com  2008-03-31 23:24:27 ---
putback Mar 31st

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.