zfs crypto discuss - Mar 2008 - [Bug 899] New: salt not being picked up by passphrase

http://defect.opensolaris.org/bz/show_bug.cgi?id=899

           Summary: salt not being picked up by passphrase
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: ACCEPTED
          Severity: major
          Priority: P3
         Component: other
        AssignedTo: ajscarp at yahoo.com
        ReportedBy: ajscarp at yahoo.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


When ''zfs create'' is called, the salt isn''t be stored
in it''s property..

Two things were wrong..

First the zfs_crypto_create() call in libzfs_dataset:zfs_create() was called
after the zcmd_write_src_nvlist() function.. That cause the property to never
be set..

Secondly, when that was moved.. there was a bug in libzfs_crypto:check_format()
that was not searching for the '','' that designates the end of
the format.. This
was probably because libzfs_crypto:parse_format() was not aware of string
lengths until recently

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=899


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |FIXINPROGRESS




--- Comment #1 from ajscarp at yahoo.com  2008-03-28 19:57:02 ---
fix known..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=899


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|FIXINPROGRESS               |FIXINSOURCE




--- Comment #2 from ajscarp at yahoo.com  2008-03-31 23:24:56 ---
putback Mar 31st

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=899


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darrenm at opensolaris.org
             Status|FIXINSOURCE                 |CLOSED
         Resolution|                            |FIXED




--- Comment #3 from Darren J Moffat <darrenm at opensolaris.org> 
2008-04-03 11:29:51 ---
I''ve verified this works now on create and key loading, closing it out.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.