Hi, I have downloaded src rpm from gitco and extracted into the /usr/src/redhat/SOURCES dir then downloaded the patches and renamed it as properly like xen-3.4.4-xsa17-qemu-xen-traditional-all.patch. Then edited the xen-x.spec file and added the patches. After that I have tried to make rpm using rpmbuild -bb xen-x.spec and I ended up with the below error, Patch #13 (xen-3.4.4-xsa17-qemu-xen-traditional-all.patch): + patch -p1 -s The text leading up to this was: -------------------------- |console: bounds check whenever changing the cursor due to an escape code | |This is XSA-17 / CVE-2012-3515 | |Signed-off-by: Ian Campbell <ian.campbell@citrix.com> | |diff --git a/console.c b/console.c |index 5e6e3d0..9984d6f 100644 |--- a/console.c |+++ b/console.c -------------------------- File to patch: Fyi : I have added the patches xsa12-all.patch, xsa14-xen-3.4-and-4.x.patch and xsa17-qemu-xen-traditional-all.patch. All the patches goes fine expect xsa17-qemu-xen-traditional-all.patch. May I know how can I apply this? _______________________________________________ Xen-users mailing list Xen-users@lists.xen.org http://lists.xen.org/xen-users
Pasi Kärkkäinen
2012-Sep-06 12:46 UTC
Re: [Xen-devel] Issue with making rpm with patch applied
On Thu, Sep 06, 2012 at 02:44:39PM +0530, kk s wrote:> Hi, > > I have downloaded src rpm from gitco and extracted into the > /usr/src/redhat/SOURCES dir then downloaded the patches and renamed it as > properly like xen-3.4.4-xsa17-qemu-xen-traditional-all.patch. Then edited > the xen-x.spec file and added the patches. After that I have tried to make > rpm using rpmbuild -bb xen-x.spec and I ended up with the below error, > > Patch #13 (xen-3.4.4-xsa17-qemu-xen-traditional-all.patch): > + patch -p1 -s > The text leading up to this was: > -------------------------- > |console: bounds check whenever changing the cursor due to an escape code > | > |This is XSA-17 / CVE-2012-3515 > | > |Signed-off-by: Ian Campbell <[1]ian.campbell@citrix.com> > | > |diff --git a/console.c b/console.c > |index 5e6e3d0..9984d6f 100644 > |--- a/console.c > |+++ b/console.c > -------------------------- > File to patch: > > Fyi : I have added the patches xsa12-all.patch, > xsa14-xen-3.4-and-4.x.patch and xsa17-qemu-xen-traditional-all.patch. All > the patches goes fine expect xsa17-qemu-xen-traditional-all.patch. > > May I know how can I apply this? >With a quick look at your email it looks like wrong -p option for patch? -- Pasi
Hi Pasi, I have tried with the -p options p1 and p0 which doesn''t help :( On Thu, Sep 6, 2012 at 6:16 PM, Pasi Kärkkäinen <pasik@iki.fi> wrote:> On Thu, Sep 06, 2012 at 02:44:39PM +0530, kk s wrote: > > Hi, > > > > I have downloaded src rpm from gitco and extracted into the > > /usr/src/redhat/SOURCES dir then downloaded the patches and renamed > it as > > properly like xen-3.4.4-xsa17-qemu-xen-traditional-all.patch. Then > edited > > the xen-x.spec file and added the patches. After that I have tried to > make > > rpm using rpmbuild -bb xen-x.spec and I ended up with the below error, > > > > Patch #13 (xen-3.4.4-xsa17-qemu-xen-traditional-all.patch): > > + patch -p1 -s > > The text leading up to this was: > > -------------------------- > > |console: bounds check whenever changing the cursor due to an escape > code > > | > > |This is XSA-17 / CVE-2012-3515 > > | > > |Signed-off-by: Ian Campbell <[1]ian.campbell@citrix.com> > > | > > |diff --git a/console.c b/console.c > > |index 5e6e3d0..9984d6f 100644 > > |--- a/console.c > > |+++ b/console.c > > -------------------------- > > File to patch: > > > > Fyi : I have added the patches xsa12-all.patch, > > xsa14-xen-3.4-and-4.x.patch and xsa17-qemu-xen-traditional-all.patch. > All > > the patches goes fine expect xsa17-qemu-xen-traditional-all.patch. > > > > May I know how can I apply this? > > > > With a quick look at your email it looks like wrong -p option for patch? > > -- Pasi > >_______________________________________________ Xen-users mailing list Xen-users@lists.xen.org http://lists.xen.org/xen-users
Pasi Kärkkäinen
2012-Sep-06 12:58 UTC
Re: [Xen-devel] Issue with making rpm with patch applied
On Thu, Sep 06, 2012 at 06:23:18PM +0530, kk s wrote:> Hi Pasi, > I have tried with the -p options p1 and p0 which doesn''t help :( >Well did you verify the file paths? Where is console.c on the xen source tree? how many directories ''deep'' in the tree? The patch only mentions a/console.c, so you might need to add some more path elements there.. -- Pasi> On Thu, Sep 6, 2012 at 6:16 PM, Pasi Kärkkäinen <[1]pasik@iki.fi> wrote: > > On Thu, Sep 06, 2012 at 02:44:39PM +0530, kk s wrote: > > Hi, > > > > I have downloaded src rpm from gitco and extracted into the > > /usr/src/redhat/SOURCES dir then downloaded the patches and renamed > it as > > properly like xen-3.4.4-xsa17-qemu-xen-traditional-all.patch. Then > edited > > the xen-x.spec file and added the patches. After that I have tried > to make > > rpm using rpmbuild -bb xen-x.spec and I ended up with the below > error, > > > > Patch #13 (xen-3.4.4-xsa17-qemu-xen-traditional-all.patch): > > + patch -p1 -s > > The text leading up to this was: > > -------------------------- > > |console: bounds check whenever changing the cursor due to an > escape code > > | > > |This is XSA-17 / CVE-2012-3515 > > | > > |Signed-off-by: Ian Campbell <[1][2]ian.campbell@citrix.com> > > | > > |diff --git a/console.c b/console.c > > |index 5e6e3d0..9984d6f 100644 > > |--- a/console.c > > |+++ b/console.c > > -------------------------- > > File to patch: > > > > Fyi : I have added the patches xsa12-all.patch, > > xsa14-xen-3.4-and-4.x.patch and > xsa17-qemu-xen-traditional-all.patch. All > > the patches goes fine expect xsa17-qemu-xen-traditional-all.patch. > > > > May I know how can I apply this? > > > > With a quick look at your email it looks like wrong -p option for patch? > -- Pasi > > References > > Visible links > 1. mailto:pasik@iki.fi > 2. mailto:ian.campbell@citrix.com
Hi Pasi, You are right. It looks like the path is wrong and I have changed from a/console.c to a/tools/ioemu-qemu-xen/console.c and as well for b/ which going fine. May I confirm is this correct file that I am applying? On Thu, Sep 6, 2012 at 6:28 PM, Pasi Kärkkäinen <pasik@iki.fi> wrote:> On Thu, Sep 06, 2012 at 06:23:18PM +0530, kk s wrote: > > Hi Pasi, > > I have tried with the -p options p1 and p0 which doesn''t help :( > > > > Well did you verify the file paths? Where is console.c on the xen source > tree? > how many directories ''deep'' in the tree? > > The patch only mentions a/console.c, so you might need to add some more > path elements there.. > > -- Pasi > > > On Thu, Sep 6, 2012 at 6:16 PM, Pasi Kärkkäinen <[1]pasik@iki.fi> > wrote: > > > > On Thu, Sep 06, 2012 at 02:44:39PM +0530, kk s wrote: > > > Hi, > > > > > > I have downloaded src rpm from gitco and extracted into the > > > /usr/src/redhat/SOURCES dir then downloaded the patches and > renamed > > it as > > > properly like xen-3.4.4-xsa17-qemu-xen-traditional-all.patch. > Then > > edited > > > the xen-x.spec file and added the patches. After that I have > tried > > to make > > > rpm using rpmbuild -bb xen-x.spec and I ended up with the below > > error, > > > > > > Patch #13 (xen-3.4.4-xsa17-qemu-xen-traditional-all.patch): > > > + patch -p1 -s > > > The text leading up to this was: > > > -------------------------- > > > |console: bounds check whenever changing the cursor due to an > > escape code > > > | > > > |This is XSA-17 / CVE-2012-3515 > > > | > > > |Signed-off-by: Ian Campbell <[1][2]ian.campbell@citrix.com> > > > | > > > |diff --git a/console.c b/console.c > > > |index 5e6e3d0..9984d6f 100644 > > > |--- a/console.c > > > |+++ b/console.c > > > -------------------------- > > > File to patch: > > > > > > Fyi : I have added the patches xsa12-all.patch, > > > xsa14-xen-3.4-and-4.x.patch and > > xsa17-qemu-xen-traditional-all.patch. All > > > the patches goes fine expect > xsa17-qemu-xen-traditional-all.patch. > > > > > > May I know how can I apply this? > > > > > > > With a quick look at your email it looks like wrong -p option for > patch? > > -- Pasi > > > > References > > > > Visible links > > 1. mailto:pasik@iki.fi > > 2. mailto:ian.campbell@citrix.com >_______________________________________________ Xen-users mailing list Xen-users@lists.xen.org http://lists.xen.org/xen-users
Hi, Everything has been done fine. I just want to make sure that I did correct for this patch issue? On Thu, Sep 6, 2012 at 6:51 PM, kk s <kks.kbase@gmail.com> wrote:> Hi Pasi, > > You are right. > > It looks like the path is wrong and I have changed from a/console.c to > a/tools/ioemu-qemu-xen/console.c and as well for b/ which going fine. > > May I confirm is this correct file that I am applying? > > On Thu, Sep 6, 2012 at 6:28 PM, Pasi Kärkkäinen <pasik@iki.fi> wrote: > >> On Thu, Sep 06, 2012 at 06:23:18PM +0530, kk s wrote: >> > Hi Pasi, >> > I have tried with the -p options p1 and p0 which doesn''t help :( >> > >> >> Well did you verify the file paths? Where is console.c on the xen source >> tree? >> how many directories ''deep'' in the tree? >> >> The patch only mentions a/console.c, so you might need to add some more >> path elements there.. >> >> -- Pasi >> >> > On Thu, Sep 6, 2012 at 6:16 PM, Pasi Kärkkäinen <[1]pasik@iki.fi> >> wrote: >> > >> > On Thu, Sep 06, 2012 at 02:44:39PM +0530, kk s wrote: >> > > Hi, >> > > >> > > I have downloaded src rpm from gitco and extracted into the >> > > /usr/src/redhat/SOURCES dir then downloaded the patches and >> renamed >> > it as >> > > properly like xen-3.4.4-xsa17-qemu-xen-traditional-all.patch. >> Then >> > edited >> > > the xen-x.spec file and added the patches. After that I have >> tried >> > to make >> > > rpm using rpmbuild -bb xen-x.spec and I ended up with the >> below >> > error, >> > > >> > > Patch #13 (xen-3.4.4-xsa17-qemu-xen-traditional-all.patch): >> > > + patch -p1 -s >> > > The text leading up to this was: >> > > -------------------------- >> > > |console: bounds check whenever changing the cursor due to an >> > escape code >> > > | >> > > |This is XSA-17 / CVE-2012-3515 >> > > | >> > > |Signed-off-by: Ian Campbell <[1][2]ian.campbell@citrix.com> >> > > | >> > > |diff --git a/console.c b/console.c >> > > |index 5e6e3d0..9984d6f 100644 >> > > |--- a/console.c >> > > |+++ b/console.c >> > > -------------------------- >> > > File to patch: >> > > >> > > Fyi : I have added the patches xsa12-all.patch, >> > > xsa14-xen-3.4-and-4.x.patch and >> > xsa17-qemu-xen-traditional-all.patch. All >> > > the patches goes fine expect >> xsa17-qemu-xen-traditional-all.patch. >> > > >> > > May I know how can I apply this? >> > > >> > >> > With a quick look at your email it looks like wrong -p option for >> patch? >> > -- Pasi >> > >> > References >> > >> > Visible links >> > 1. mailto:pasik@iki.fi >> > 2. mailto:ian.campbell@citrix.com >> > >_______________________________________________ Xen-users mailing list Xen-users@lists.xen.org http://lists.xen.org/xen-users