Xen devel - Sep 2013 - [PATCH v2] xen/x86: add a comment regarding how to get the VCPU ID on HVM

Add a note to the public headers regarding how to get the VCPU ID for
HVM guests (on x86).

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Matt Wilson <msw@amazon.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Matt Wilson <msw@amazon.com>
---
This is what Linux PVHVM does AFAIK, and also what I've been using in
my FreeBSD PVHVM series, but it's not written anywere.
---
Changes since v1:
 * Reworded the comment as requested by Matt.
---
 xen/include/public/vcpu.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h
index e888daf..f09367a 100644
--- a/xen/include/public/vcpu.h
+++ b/xen/include/public/vcpu.h
@@ -35,6 +35,10 @@
  * @cmd        == VCPUOP_??? (VCPU operation).
  * @vcpuid     == VCPU to operate on.
  * @extra_args == Operation-specific extra arguments (NULL if none).
+ *
+ * For x86 HVM domains that use VCPU operations the VCPU ID is the ACPI
+ * Processor ID of the CPU (not to be confused with the APIC ID), as
+ * fetched from the MADT table.
  */
 
 /*
-- 
1.7.7.5 (Apple Git-26)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Ping?

On 23/09/13 20:07, Roger Pau Monne wrote:
> Add a note to the public headers regarding how to get the VCPU ID for
> HVM guests (on x86).
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Acked-by: Matt Wilson <msw@amazon.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Matt Wilson <msw@amazon.com>
> ---
> This is what Linux PVHVM does AFAIK, and also what I've been using in
> my FreeBSD PVHVM series, but it's not written anywere.
> ---
> Changes since v1:
>  * Reworded the comment as requested by Matt.
> ---
>  xen/include/public/vcpu.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h
> index e888daf..f09367a 100644
> --- a/xen/include/public/vcpu.h
> +++ b/xen/include/public/vcpu.h
> @@ -35,6 +35,10 @@
>   * @cmd        == VCPUOP_??? (VCPU operation).
>   * @vcpuid     == VCPU to operate on.
>   * @extra_args == Operation-specific extra arguments (NULL if none).
> + *
> + * For x86 HVM domains that use VCPU operations the VCPU ID is the ACPI
> + * Processor ID of the CPU (not to be confused with the APIC ID), as
> + * fetched from the MADT table.
>   */
>  
>  /*
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel