Matt Wilson
2013-Aug-28 18:59 UTC
[PATCH] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
The DMI checks that force the use of the bigsmp APIC driver are for
systems that are no longer supported by Xen (32-bit x86).
Signed-off-by: Matt Wilson <msw@amazon.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/arch/x86/genapic/bigsmp.c | 30 +-----------------------------
1 files changed, 1 insertions(+), 29 deletions(-)
diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c
index 96b23d6..491a916 100644
--- a/xen/arch/x86/genapic/bigsmp.c
+++ b/xen/arch/x86/genapic/bigsmp.c
@@ -8,36 +8,9 @@
#include <xen/kernel.h>
#include <xen/smp.h>
#include <xen/init.h>
-#include <xen/dmi.h>
#include <asm/mach-default/mach_mpparse.h>
#include <asm/io_apic.h>
-static __init int force_bigsmp(struct dmi_system_id *d)
-{
- printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n",
d->ident);
- def_to_bigsmp = 1;
- return 0;
-}
-
-
-static struct dmi_system_id __initdata bigsmp_dmi_table[] = {
- { force_bigsmp, "HP ProLiant DL760 G2", {
- DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
- DMI_MATCH(DMI_BIOS_VERSION, "P44-"),
- }},
-
- { force_bigsmp, "HP ProLiant DL740", {
- DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
- DMI_MATCH(DMI_BIOS_VERSION, "P47-"),
- }},
- { force_bigsmp, "UNISYS ES7000-ONE", {
- DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE")
- }},
-
- { }
-};
-
-
static __init int probe_bigsmp(void)
{
/*
@@ -47,8 +20,7 @@ static __init int probe_bigsmp(void)
if (acpi_gbl_FADT.flags &
(ACPI_FADT_APIC_CLUSTER | ACPI_FADT_APIC_PHYSICAL))
def_to_bigsmp = 1;
- else if (!def_to_bigsmp)
- dmi_check_system(bigsmp_dmi_table);
+
return def_to_bigsmp;
}
--
1.7.4.5
Andrew Cooper
2013-Aug-28 19:25 UTC
Re: [PATCH] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
On 28/08/13 19:59, Matt Wilson wrote:> The DMI checks that force the use of the bigsmp APIC driver are for > systems that are no longer supported by Xen (32-bit x86). > > Signed-off-by: Matt Wilson <msw@amazon.com> > Cc: Keir Fraser <keir@xen.org> > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>I did some googling. While the two HP machines do indeed only support 32bit cpus (Intel ''Gallatin'' series), http://www.serverwatch.com/hreviews/article.php/3655386 indicates that the ES7000/ONE can be configured with 64bit Xeon CPUs, and is therefore still supported by Xen. ~Andrew> --- > xen/arch/x86/genapic/bigsmp.c | 30 +----------------------------- > 1 files changed, 1 insertions(+), 29 deletions(-) > > diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c > index 96b23d6..491a916 100644 > --- a/xen/arch/x86/genapic/bigsmp.c > +++ b/xen/arch/x86/genapic/bigsmp.c > @@ -8,36 +8,9 @@ > #include <xen/kernel.h> > #include <xen/smp.h> > #include <xen/init.h> > -#include <xen/dmi.h> > #include <asm/mach-default/mach_mpparse.h> > #include <asm/io_apic.h> > > -static __init int force_bigsmp(struct dmi_system_id *d) > -{ > - printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n", d->ident); > - def_to_bigsmp = 1; > - return 0; > -} > - > - > -static struct dmi_system_id __initdata bigsmp_dmi_table[] = { > - { force_bigsmp, "HP ProLiant DL760 G2", { > - DMI_MATCH(DMI_BIOS_VENDOR, "HP"), > - DMI_MATCH(DMI_BIOS_VERSION, "P44-"), > - }}, > - > - { force_bigsmp, "HP ProLiant DL740", { > - DMI_MATCH(DMI_BIOS_VENDOR, "HP"), > - DMI_MATCH(DMI_BIOS_VERSION, "P47-"), > - }}, > - { force_bigsmp, "UNISYS ES7000-ONE", { > - DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE") > - }}, > - > - { } > -}; > - > - > static __init int probe_bigsmp(void) > { > /* > @@ -47,8 +20,7 @@ static __init int probe_bigsmp(void) > if (acpi_gbl_FADT.flags & > (ACPI_FADT_APIC_CLUSTER | ACPI_FADT_APIC_PHYSICAL)) > def_to_bigsmp = 1; > - else if (!def_to_bigsmp) > - dmi_check_system(bigsmp_dmi_table); > + > return def_to_bigsmp; > } >
Matt Wilson
2013-Aug-28 20:58 UTC
Re: [PATCH] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
On Wed, Aug 28, 2013 at 08:25:08PM +0100, Andrew Cooper wrote:> On 28/08/13 19:59, Matt Wilson wrote: > > The DMI checks that force the use of the bigsmp APIC driver are for > > systems that are no longer supported by Xen (32-bit x86). > > > > Signed-off-by: Matt Wilson <msw@amazon.com> > > Cc: Keir Fraser <keir@xen.org> > > Cc: Jan Beulich <jbeulich@suse.com> > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > I did some googling. > > While the two HP machines do indeed only support 32bit cpus (Intel > ''Gallatin'' series), > > http://www.serverwatch.com/hreviews/article.php/3655386 > > indicates that the ES7000/ONE can be configured with 64bit Xeon CPUs, > and is therefore still supported by Xen.Indeed. I''m hoping that such systems would be setting the clustered APIC flag in FADT, which would have the same effect. I''ve added some @unisys.com email addresses from past discussions. --msw> > static __init int probe_bigsmp(void) > > { > > /* > > @@ -47,8 +20,7 @@ static __init int probe_bigsmp(void) > > if (acpi_gbl_FADT.flags & > > (ACPI_FADT_APIC_CLUSTER | ACPI_FADT_APIC_PHYSICAL)) > > def_to_bigsmp = 1; > > - else if (!def_to_bigsmp) > > - dmi_check_system(bigsmp_dmi_table); > > + > > return def_to_bigsmp; > > } > > >
Aravindh Puthiyaparambil (aravindp)
2013-Aug-28 22:24 UTC
Re: [PATCH] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
> > > The DMI checks that force the use of the bigsmp APIC driver are for > > > systems that are no longer supported by Xen (32-bit x86). > > > > > > Signed-off-by: Matt Wilson <msw@amazon.com> > > > Cc: Keir Fraser <keir@xen.org> > > > Cc: Jan Beulich <jbeulich@suse.com> > > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > > > I did some googling. > > > > While the two HP machines do indeed only support 32bit cpus (Intel > > ''Gallatin'' series), > > > > http://www.serverwatch.com/hreviews/article.php/3655386 > > > > indicates that the ES7000/ONE can be configured with 64bit Xeon CPUs, > > and is therefore still supported by Xen. > > Indeed. I''m hoping that such systems would be setting the clustered APIC > flag in FADT, which would have the same effect. I''ve added some > @unisys.com email addresses from past discussions.I should know the answer to the question as I got Xen running on those systems but I don''t remember :-) Some ES7000s ran in clustered APIC mode while some of the later models could run in physical flat mode. I have CCed Natalie Protasevich who might remember. Thanks, Aravindh> > > static __init int probe_bigsmp(void) { > > > /* > > > @@ -47,8 +20,7 @@ static __init int probe_bigsmp(void) > > > if (acpi_gbl_FADT.flags & > > > (ACPI_FADT_APIC_CLUSTER | ACPI_FADT_APIC_PHYSICAL)) > > > def_to_bigsmp = 1; > > > - else if (!def_to_bigsmp) > > > - dmi_check_system(bigsmp_dmi_table); > > > + > > > return def_to_bigsmp; > > > } > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
Jan Beulich
2013-Aug-29 07:14 UTC
Re: [PATCH] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
>>> On 28.08.13 at 22:58, Matt Wilson <msw@amazon.com> wrote: > On Wed, Aug 28, 2013 at 08:25:08PM +0100, Andrew Cooper wrote: >> On 28/08/13 19:59, Matt Wilson wrote: >> > The DMI checks that force the use of the bigsmp APIC driver are for >> > systems that are no longer supported by Xen (32-bit x86). >> > >> > Signed-off-by: Matt Wilson <msw@amazon.com> >> > Cc: Keir Fraser <keir@xen.org> >> > Cc: Jan Beulich <jbeulich@suse.com> >> > Cc: Andrew Cooper <andrew.cooper3@citrix.com> >> >> I did some googling. >> >> While the two HP machines do indeed only support 32bit cpus (Intel >> ''Gallatin'' series), >> >> http://www.serverwatch.com/hreviews/article.php/3655386 >> >> indicates that the ES7000/ONE can be configured with 64bit Xeon CPUs, >> and is therefore still supported by Xen. > > Indeed. I''m hoping that such systems would be setting the clustered > APIC flag in FADT, which would have the same effect. I''ve added some > @unisys.com email addresses from past discussions.I wouldn''t want to rely on that flag. Let''s just keep that one DMI entry. Jan
Matt Wilson
2013-Aug-29 20:38 UTC
[PATCH v2] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
The DMI checks that force the use of the bigsmp APIC driver are for
systems that are no longer supported by Xen (32-bit x86).
Signed-off-by: Matt Wilson <msw@amazon.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Changes in v2:
- only remove obsolete HP systems, leave UNISYS ES7000-ONE behind
---
xen/arch/x86/genapic/bigsmp.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c
index 96b23d6..411ddcf 100644
--- a/xen/arch/x86/genapic/bigsmp.c
+++ b/xen/arch/x86/genapic/bigsmp.c
@@ -21,15 +21,6 @@ static __init int force_bigsmp(struct dmi_system_id *d)
static struct dmi_system_id __initdata bigsmp_dmi_table[] = {
- { force_bigsmp, "HP ProLiant DL760 G2", {
- DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
- DMI_MATCH(DMI_BIOS_VERSION, "P44-"),
- }},
-
- { force_bigsmp, "HP ProLiant DL740", {
- DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
- DMI_MATCH(DMI_BIOS_VERSION, "P47-"),
- }},
{ force_bigsmp, "UNISYS ES7000-ONE", {
DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE")
}},
--
1.7.4.5
Keir Fraser
2013-Aug-30 05:23 UTC
Re: [PATCH v2] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
On 29/08/2013 21:38, "Matt Wilson" <msw@amazon.com> wrote:> The DMI checks that force the use of the bigsmp APIC driver are for > systems that are no longer supported by Xen (32-bit x86). > > Signed-off-by: Matt Wilson <msw@amazon.com> > Cc: Keir Fraser <keir@xen.org> > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>Acked-by: Keir Fraser <keir@xen.org>> Changes in v2: > - only remove obsolete HP systems, leave UNISYS ES7000-ONE behind > --- > xen/arch/x86/genapic/bigsmp.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c > index 96b23d6..411ddcf 100644 > --- a/xen/arch/x86/genapic/bigsmp.c > +++ b/xen/arch/x86/genapic/bigsmp.c > @@ -21,15 +21,6 @@ static __init int force_bigsmp(struct dmi_system_id *d) > > > static struct dmi_system_id __initdata bigsmp_dmi_table[] = { > - { force_bigsmp, "HP ProLiant DL760 G2", { > - DMI_MATCH(DMI_BIOS_VENDOR, "HP"), > - DMI_MATCH(DMI_BIOS_VERSION, "P44-"), > - }}, > - > - { force_bigsmp, "HP ProLiant DL740", { > - DMI_MATCH(DMI_BIOS_VENDOR, "HP"), > - DMI_MATCH(DMI_BIOS_VERSION, "P47-"), > - }}, > { force_bigsmp, "UNISYS ES7000-ONE", { > DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE") > }},
Andrew Cooper
2013-Aug-30 08:35 UTC
Re: [PATCH v2] x86/apic: remove DMI checks in bigsmp driver for obsolete systems
On 29/08/13 21:38, Matt Wilson wrote:> The DMI checks that force the use of the bigsmp APIC driver are for > systems that are no longer supported by Xen (32-bit x86). > > Signed-off-by: Matt Wilson <msw@amazon.com> > Cc: Keir Fraser <keir@xen.org> > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>> > Changes in v2: > - only remove obsolete HP systems, leave UNISYS ES7000-ONE behind > --- > xen/arch/x86/genapic/bigsmp.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c > index 96b23d6..411ddcf 100644 > --- a/xen/arch/x86/genapic/bigsmp.c > +++ b/xen/arch/x86/genapic/bigsmp.c > @@ -21,15 +21,6 @@ static __init int force_bigsmp(struct dmi_system_id *d) > > > static struct dmi_system_id __initdata bigsmp_dmi_table[] = { > - { force_bigsmp, "HP ProLiant DL760 G2", { > - DMI_MATCH(DMI_BIOS_VENDOR, "HP"), > - DMI_MATCH(DMI_BIOS_VERSION, "P44-"), > - }}, > - > - { force_bigsmp, "HP ProLiant DL740", { > - DMI_MATCH(DMI_BIOS_VENDOR, "HP"), > - DMI_MATCH(DMI_BIOS_VERSION, "P47-"), > - }}, > { force_bigsmp, "UNISYS ES7000-ONE", { > DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE") > }},