flight 16260 xen-4.2-testing real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/16260/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-i386-i386-xl 5 xen-boot fail REGR. vs. 16228
test-i386-i386-xl-qemuu-winxpsp3 5 xen-boot fail REGR. vs. 16228
test-i386-i386-win 5 xen-boot fail REGR. vs. 16228
test-i386-i386-xl-winxpsp3 5 xen-boot fail REGR. vs. 16228
Tests which are failing intermittently (not blocking):
test-amd64-amd64-xl-sedf-pin 11 guest-localmigrate fail pass in 16232
test-amd64-amd64-xl-sedf 11 guest-localmigrate fail pass in 16232
test-amd64-amd64-xl-qemut-winxpsp3 7 windows-install fail pass in 16232
test-amd64-i386-xl-win7-amd64 12 guest-localmigrate/x10 fail in 16232 pass in
16260
test-i386-i386-xl-qemut-win 3 host-install(3) broken in 16232 pass in 16260
Tests which did not succeed, but are not blocking:
build-armhf 4 xen-build fail never pass
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
test-amd64-i386-xl-winxpsp3-vcpus1 13 guest-stop fail never pass
test-amd64-amd64-xl-win 13 guest-stop fail never pass
test-amd64-amd64-xl-qemut-win7-amd64 13 guest-stop fail never pass
test-amd64-i386-xl-qemut-win7-amd64 13 guest-stop fail never pass
test-amd64-i386-win-vcpus1 16 leak-check/check fail never pass
test-amd64-amd64-xl-win7-amd64 13 guest-stop fail never pass
test-amd64-amd64-xl-qemuu-win7-amd64 9 guest-localmigrate fail never pass
test-amd64-amd64-xl-qemut-win 13 guest-stop fail never pass
test-amd64-i386-xl-win7-amd64 13 guest-stop fail never pass
test-amd64-amd64-qemut-win 16 leak-check/check fail never pass
test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass
test-amd64-i386-xl-qemut-winxpsp3-vcpus1 13 guest-stop fail never pass
test-amd64-i386-xl-win-vcpus1 13 guest-stop fail never pass
test-amd64-i386-xl-qemut-win-vcpus1 13 guest-stop fail never pass
test-amd64-i386-qemut-win-vcpus1 16 leak-check/check fail never pass
test-i386-i386-xl-qemut-win 13 guest-stop fail never pass
test-amd64-amd64-xl-qemuu-winxpsp3 9 guest-localmigrate fail never pass
test-amd64-i386-win 16 leak-check/check fail never pass
test-amd64-amd64-xl-winxpsp3 13 guest-stop fail never pass
test-amd64-i386-qemut-win 16 leak-check/check fail never pass
test-i386-i386-xl-qemut-winxpsp3 13 guest-stop fail never pass
test-i386-i386-qemut-win 16 leak-check/check fail never pass
test-i386-i386-xl-win 13 guest-stop fail never pass
test-amd64-i386-xend-qemut-winxpsp3 16 leak-check/check fail never pass
test-amd64-amd64-win 16 leak-check/check fail never pass
test-amd64-amd64-xl-qemut-winxpsp3 13 guest-stop fail in 16232 never pass
version targeted for testing:
xen 6f0f339dd4378d062a211969f45cd23af12bf386
baseline version:
xen 61401264eb00fae4ee4efc8e9a5067449283207b
------------------------------------------------------------
People who touched revisions under test:
Ian Jackson <ian.jackson@eu.citrix.com>
Jim Fehlig <jfehlig@suse.com>
------------------------------------------------------------
jobs:
build-amd64 pass
build-armhf fail
build-i386 pass
build-amd64-oldkern pass
build-i386-oldkern pass
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl pass
test-amd64-i386-xl pass
test-i386-i386-xl fail
test-amd64-i386-rhel6hvm-amd pass
test-amd64-i386-qemut-rhel6hvm-amd pass
test-amd64-i386-qemuu-rhel6hvm-amd pass
test-amd64-amd64-xl-qemut-win7-amd64 fail
test-amd64-i386-xl-qemut-win7-amd64 fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-amd64-xl-win7-amd64 fail
test-amd64-i386-xl-win7-amd64 fail
test-amd64-i386-xl-credit2 pass
test-amd64-amd64-xl-pcipt-intel fail
test-amd64-i386-rhel6hvm-intel pass
test-amd64-i386-qemut-rhel6hvm-intel pass
test-amd64-i386-qemuu-rhel6hvm-intel pass
test-amd64-i386-xl-multivcpu pass
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-i386-i386-pair pass
test-amd64-amd64-xl-sedf-pin fail
test-amd64-amd64-pv pass
test-amd64-i386-pv pass
test-i386-i386-pv pass
test-amd64-amd64-xl-sedf fail
test-amd64-i386-win-vcpus1 fail
test-amd64-i386-qemut-win-vcpus1 fail
test-amd64-i386-xl-qemut-win-vcpus1 fail
test-amd64-i386-xl-win-vcpus1 fail
test-amd64-i386-xl-qemut-winxpsp3-vcpus1 fail
test-amd64-i386-xl-winxpsp3-vcpus1 fail
test-amd64-amd64-win fail
test-amd64-i386-win fail
test-i386-i386-win fail
test-amd64-amd64-qemut-win fail
test-amd64-i386-qemut-win fail
test-i386-i386-qemut-win fail
test-amd64-amd64-xl-qemut-win fail
test-i386-i386-xl-qemut-win fail
test-amd64-amd64-xl-win fail
test-i386-i386-xl-win fail
test-amd64-i386-xend-qemut-winxpsp3 fail
test-amd64-amd64-xl-qemut-winxpsp3 fail
test-i386-i386-xl-qemut-winxpsp3 fail
test-amd64-amd64-xl-qemuu-winxpsp3 fail
test-i386-i386-xl-qemuu-winxpsp3 fail
test-amd64-i386-xend-winxpsp3 fail
test-amd64-amd64-xl-winxpsp3 fail
test-i386-i386-xl-winxpsp3 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
commit 6f0f339dd4378d062a211969f45cd23af12bf386
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Wed Jan 23 16:53:11 2013 +0000
libxl: fix stale timeout event callback race
Because there is not necessarily any lock held at the point the
application (eg, libvirt) calls libxl_osevent_occurred_timeout, in a
multithreaded program those calls may be arbitrarily delayed in
relation to other activities within the program.
Specifically this means when ->timeout_deregister returns, libxl does
not know whether it can safely dispose of the for_libxl value or
whether it needs to retain it in case of an in-progress call to
_occurred_timeout.
The interface could be fixed by requiring the application to make a
new call into libxl to say that the deregistration was complete.
However that new call would have to be threaded through the
application''s event loop; this is complicated and some application
authors are likely not to implement it properly. Furthermore the
easiest way to implement this facility in most event loops is to queue
up a time event for "now".
Shortcut all of this by having libxl always call timeout_modify
setting abs={0,0} (ie, ASAP) instead of timeout_deregister. This will
cause the application to call _occurred_timeout. When processing this
calldown we see that we were no longer actually interested and simply
throw it away.
Additionally, there is a race between _occurred_timeout and
->timeout_modify. If libxl ever adjusts the deadline for a timeout
the application may already be in the process of calling _occurred, in
which case the situation with for_app''s lifetime becomes very
complicated. Therefore abolish libxl__ev_time_modify_{abs,rel} (which
have no callers) and promise to the application only ever to call
->timeout_modify with abs=={0,0}. The application still needs to cope
with ->timeout_modify racing with its internal function which calls
_occurred_timeout. Document this.
This is a forwards-compatible change for applications using the libxl
API, and will hopefully eliminate these races in callback-supplying
applications (such as libvirt) without the need for corresponding
changes to the application. (It is possible that this might expose
bugs in applications, though, as previously libxl would never call
libxl_osevent_hooks->timeout_modify and now it never calls
->timeout_deregister).
For clarity, fold the body of time_register_finite into its one
remaining call site. This makes the semantics of ev->infinite
slightly clearer.
Cc: Bamvor Jian Zhang <bjzhang@suse.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>
Tested-by: Jim Fehlig <jfehlig@suse.com>
Acked-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
(qemu changes not included)
>>> On 24.02.13 at 10:46, xen.org <ian.jackson@eu.citrix.com> wrote: > flight 16260 xen-4.2-testing real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/16260/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-i386-i386-xl 5 xen-boot fail REGR. vs. 16228 > test-i386-i386-xl-qemuu-winxpsp3 5 xen-boot fail REGR. vs. 16228 > test-i386-i386-win 5 xen-boot fail REGR. vs. 16228 > test-i386-i386-xl-winxpsp3 5 xen-boot fail REGR. vs. 16228This is because I didn''t pay attention to the fact that 2ea6abb8e60cf557b20b8a9904deb73433103d9b can do what it does validly only on x86-64. Working on a fix... Jan
>>> On 25.02.13 at 11:23, "Jan Beulich" <JBeulich@suse.com> wrote: >>>> On 24.02.13 at 10:46, xen.org <ian.jackson@eu.citrix.com> wrote: >> flight 16260 xen-4.2-testing real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/16260/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-i386-i386-xl 5 xen-boot fail REGR. vs. 16228 >> test-i386-i386-xl-qemuu-winxpsp3 5 xen-boot fail REGR. vs. 16228 >> test-i386-i386-win 5 xen-boot fail REGR. vs. 16228 >> test-i386-i386-xl-winxpsp3 5 xen-boot fail REGR. vs. 16228 > > This is because I didn''t pay attention to the fact that > 2ea6abb8e60cf557b20b8a9904deb73433103d9b can do > what it does validly only on x86-64. Working on a fix...And this is the fix I''m going to commit: x86_32: fix acpi_dmar_init() map_pages_to_xen() can''t be used here on x86_32, need to use up to 2 newly introduced fixmap entries for this instead. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -776,6 +776,7 @@ out: } #ifdef CONFIG_X86 +#include <asm/fixmap.h> #include <asm/tboot.h> /* ACPI tables may not be DMA protected by tboot, so use DMAR copy */ /* SINIT saved in SinitMleData in TXT heap (which is DMA protected) */ @@ -792,12 +793,26 @@ int __init acpi_dmar_init(void) if ( ACPI_SUCCESS(acpi_get_table_phys(ACPI_SIG_DMAR, 0, &dmar_addr, &dmar_len)) ) { +#ifdef CONFIG_X86_32 + if ( dmar_addr + dmar_len > (DIRECTMAP_MBYTES << 20) ) + { + unsigned long offset = dmar_addr & (PAGE_SIZE - 1); + unsigned long mapped_size = PAGE_SIZE - offset; + + set_fixmap(FIX_DMAR_ZAP_LO, dmar_addr); + if ( mapped_size < sizeof(*dmar_table) ) + set_fixmap(FIX_DMAR_ZAP_HI, dmar_addr + PAGE_SIZE); + dmar_table = (void *)fix_to_virt(FIX_DMAR_ZAP_LO) + offset; + goto exit; + } +#endif map_pages_to_xen((unsigned long)__va(dmar_addr), PFN_DOWN(dmar_addr), PFN_UP(dmar_addr + dmar_len) - PFN_DOWN(dmar_addr), PAGE_HYPERVISOR); dmar_table = __va(dmar_addr); } + exit: __attribute__((__unused__)) return parse_dmar_table(acpi_parse_dmar); } --- a/xen/include/asm-x86/fixmap.h +++ b/xen/include/asm-x86/fixmap.h @@ -37,6 +37,8 @@ enum fixed_addresses { FIX_PAE_HIGHMEM_END = FIX_PAE_HIGHMEM_0 + NR_CPUS-1, #define FIX_VGC_END FIX_PAE_HIGHMEM_0 #define FIX_VGC_BEGIN FIX_PAE_HIGHMEM_END + FIX_DMAR_ZAP_HI, + FIX_DMAR_ZAP_LO, #else FIX_VGC_END, FIX_VGC_BEGIN = FIX_VGC_END _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Reasonably Related Threads
- [xen-unstable test] 22184: regressions - trouble: broken/fail/pass
- [xen-unstable test] 22043: regressions - trouble: blocked/broken/fail/pass
- [xen-4.1-testing test] 14679: tolerable FAIL - PUSHED
- [xen-4.1-testing test] 18782: regressions - FAIL
- [xen-4.1-testing test] 19846: regressions - trouble: broken/fail/pass