George Dunlap
2012-Mar-27  15:01 UTC
[PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru
The e820_sanitize() function in libxl_pci.c expects one of its arguments to
be non-zero; but since a recent changeset, it can typically expect *to be*
zero.  Since the zero case is handled properly, just remove the check.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r d35a117afa2f -r f9ce45c9f984 tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c	Tue Mar 27 15:25:07 2012 +0200
+++ b/tools/libxl/libxl_pci.c	Tue Mar 27 16:01:21 2012 +0100
@@ -1177,7 +1177,7 @@ static int e820_sanitize(libxl_ctx *ctx,
     uint32_t i, idx = 0, nr;
     struct e820entry e820[E820MAX];
 
-    if (!src || !map_limitkb || !balloon_kb || !nr_entries)
+    if (!src || !map_limitkb || !nr_entries)
         return ERROR_INVAL;
 
     nr = *nr_entries;
Ian Jackson
2012-Apr-02  16:22 UTC
Re: [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru
George Dunlap writes ("[Xen-devel] [PATCH] libxl: Handle non-ballooned,
zero slackmem properly for pci passthru"):> The e820_sanitize() function in libxl_pci.c expects one of its arguments to
> be non-zero; but since a recent changeset, it can typically expect *to be*
> zero.  Since the zero case is handled properly, just remove the check.
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reasonably Related Threads
- memory map issues with PV PCI passthrough
- [PATCH 00/13] Coverity fixes for libxl
- [PATCH] libxl: When checking BDF of existing slots, function should be decimal, not hex
- [PATCH] libxl: fix segfault on device assignement
- [PATCH 1 of 2] libxl: fix cold plugged PCI devices with stubdomains