Stefano Stabellini
2011-Jan-25 15:38 UTC
[Xen-devel] [PATCH] libxl: fix segfault on device assignement
Fix a xl/libxl segfault when assigning a device to the guest (bug
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1713).
Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff -r b05892ff0fce tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c Tue Jan 25 15:14:52 2011 +0000
+++ b/tools/libxl/libxl_pci.c Tue Jan 25 15:34:43 2011 +0000
@@ -268,7 +268,7 @@ static int libxl_create_pci_backend(libx
for (i = 0; i < num; i++, pcidev++)
libxl_create_pci_backend_device(gc, back, i, pcidev);
- flexarray_vappend(back, "num_devs", libxl__sprintf(gc,
"%d", num));
+ flexarray_vappend(back, "num_devs", libxl__sprintf(gc,
"%d", num), NULL);
flexarray_vappend(front,
"backend-id", libxl__sprintf(gc,
"%d", 0),
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2011-Jan-25 15:42 UTC
Re: [Xen-devel] [PATCH] libxl: fix segfault on device assignement
On Tue, 2011-01-25 at 15:38 +0000, Stefano Stabellini wrote:> Fix a xl/libxl segfault when assigning a device to the guest (bug > http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1713). > > Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>Sorry about that, Acked-by: Ian Campbell <ian.campbell@citrix.com>> > diff -r b05892ff0fce tools/libxl/libxl_pci.c > --- a/tools/libxl/libxl_pci.c Tue Jan 25 15:14:52 2011 +0000 > +++ b/tools/libxl/libxl_pci.c Tue Jan 25 15:34:43 2011 +0000 > @@ -268,7 +268,7 @@ static int libxl_create_pci_backend(libx > for (i = 0; i < num; i++, pcidev++) > libxl_create_pci_backend_device(gc, back, i, pcidev); > > - flexarray_vappend(back, "num_devs", libxl__sprintf(gc, "%d", num)); > + flexarray_vappend(back, "num_devs", libxl__sprintf(gc, "%d", num), NULL); > > flexarray_vappend(front, > "backend-id", libxl__sprintf(gc, "%d", 0), > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jan-25 18:22 UTC
Re: [Xen-devel] [PATCH] libxl: fix segfault on device assignement
Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: fix segfault on device
assignement"):> On Tue, 2011-01-25 at 15:38 +0000, Stefano Stabellini wrote:
> > Fix a xl/libxl segfault when assigning a device to the guest (bug
> > http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1713).
> >
> > Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
> > Signed-off-by: Stefano Stabellini
<stefano.stabellini@eu.citrix.com>
Applied, thanks.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel