Olaf Hering
2012-Mar-16 18:56 UTC
[PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
# HG changeset patch # User Olaf Hering <olaf@aepfle.de> # Date 1331924173 -3600 # Node ID bf1d5778ffd10858b402068b9473e410791ebd07 # Parent 72e6530b29463f0913af365f5d085d94ff75627c tools: specify datadir for qemu-xen build to fix firmware loading qemu-xen does currently not find the firmware files, such as vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix /usr/local. Use SHAREDIR/xen/qemu-xen as directory so that it can coexist with qemu-traditional. Signed-off-by: Olaf Hering <olaf@aepfle.de> diff -r 72e6530b2946 -r bf1d5778ffd1 tools/Makefile --- a/tools/Makefile +++ b/tools/Makefile @@ -156,6 +156,7 @@ subdir-all-qemu-xen-dir subdir-install-q --extra-ldflags="-L$(XEN_ROOT)/tools/libxc \ -L$(XEN_ROOT)/tools/xenstore" \ --bindir=$(LIBEXEC) \ + --datadir=$(SHAREDIR)/xen/qemu-xen \ --disable-kvm \ --python=$(PYTHON) \ $(IOEMU_CONFIGURE_CROSS); \
Fantu
2012-Mar-19 10:16 UTC
Re: [PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
Olaf Hering-2 wrote> > # HG changeset patch > # User Olaf Hering <olaf@> > # Date 1331924173 -3600 > # Node ID bf1d5778ffd10858b402068b9473e410791ebd07 > # Parent 72e6530b29463f0913af365f5d085d94ff75627c > tools: specify datadir for qemu-xen build to fix firmware loading > > qemu-xen does currently not find the firmware files, such as > vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix > /usr/local. Use SHAREDIR/xen/qemu-xen as directory so that it can coexist > with > qemu-traditional. > > Signed-off-by: Olaf Hering <olaf@> > > diff -r 72e6530b2946 -r bf1d5778ffd1 tools/Makefile > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -156,6 +156,7 @@ subdir-all-qemu-xen-dir subdir-install-q > --extra-ldflags="-L$(XEN_ROOT)/tools/libxc \ > -L$(XEN_ROOT)/tools/xenstore" \ > --bindir=$(LIBEXEC) \ > + --datadir=$(SHAREDIR)/xen/qemu-xen \ > --disable-kvm \ > --python=$(PYTHON) \ > $(IOEMU_CONFIGURE_CROSS); \ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@.xen > http://lists.xen.org/xen-devel >Patch tried, seems ok, unfortunately does not solve the problem with vga qxl. -- View this message in context: http://xen.1045712.n5.nabble.com/PATCH-tools-specify-datadir-for-qemu-xen-build-to-fix-firmware-loading-tp5572168p5576619.html Sent from the Xen - Dev mailing list archive at Nabble.com.
Ian Campbell
2012-Mar-19 11:14 UTC
Re: [PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
On Mon, 2012-03-19 at 11:14 +0000, Stefano Stabellini wrote:> On Fri, 16 Mar 2012, Olaf Hering wrote: > > # HG changeset patch > > # User Olaf Hering <olaf@aepfle.de> > > # Date 1331924173 -3600 > > # Node ID bf1d5778ffd10858b402068b9473e410791ebd07 > > # Parent 72e6530b29463f0913af365f5d085d94ff75627c > > tools: specify datadir for qemu-xen build to fix firmware loading > > > > qemu-xen does currently not find the firmware files, such as > > vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix > > /usr/local. Use SHAREDIR/xen/qemu-xen as directory so that it can coexist with > > qemu-traditional. > > Actually it shouldn''t be a problem of firmware files, that QEMU doesn''t > load by itself,Upstream qemu + SeaBIOS uses the emulated ROM BARs to load the appropriate option ROM (e.g. etherboot) for each emulated device. AIUI these are loaded from these firmware files by qemu at runtime. This differs from qemu-xen-traditional+ROMBIOS where the BIOS ROMs were baked into the hvmloader binary and pre-loaded into RAM by hvmloader. So I think the path to these firmware files does matter. Ian.> rather it should be an issue of keymap files. > > > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > > > diff -r 72e6530b2946 -r bf1d5778ffd1 tools/Makefile > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -156,6 +156,7 @@ subdir-all-qemu-xen-dir subdir-install-q > > --extra-ldflags="-L$(XEN_ROOT)/tools/libxc \ > > -L$(XEN_ROOT)/tools/xenstore" \ > > --bindir=$(LIBEXEC) \ > > + --datadir=$(SHAREDIR)/xen/qemu-xen \ > > I think that $(SHAREDIR)/qemu-xen makes more sense > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
Stefano Stabellini
2012-Mar-19 11:14 UTC
Re: [PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
On Fri, 16 Mar 2012, Olaf Hering wrote:> # HG changeset patch > # User Olaf Hering <olaf@aepfle.de> > # Date 1331924173 -3600 > # Node ID bf1d5778ffd10858b402068b9473e410791ebd07 > # Parent 72e6530b29463f0913af365f5d085d94ff75627c > tools: specify datadir for qemu-xen build to fix firmware loading > > qemu-xen does currently not find the firmware files, such as > vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix > /usr/local. Use SHAREDIR/xen/qemu-xen as directory so that it can coexist with > qemu-traditional.Actually it shouldn''t be a problem of firmware files, that QEMU doesn''t load by itself, rather it should be an issue of keymap files.> Signed-off-by: Olaf Hering <olaf@aepfle.de> > > diff -r 72e6530b2946 -r bf1d5778ffd1 tools/Makefile > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -156,6 +156,7 @@ subdir-all-qemu-xen-dir subdir-install-q > --extra-ldflags="-L$(XEN_ROOT)/tools/libxc \ > -L$(XEN_ROOT)/tools/xenstore" \ > --bindir=$(LIBEXEC) \ > + --datadir=$(SHAREDIR)/xen/qemu-xen \I think that $(SHAREDIR)/qemu-xen makes more sense
Olaf Hering
2012-Mar-19 12:43 UTC
Re: [PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
On Mon, Mar 19, Stefano Stabellini wrote:> On Fri, 16 Mar 2012, Olaf Hering wrote: > > tools: specify datadir for qemu-xen build to fix firmware loading> > diff -r 72e6530b2946 -r bf1d5778ffd1 tools/Makefile > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -156,6 +156,7 @@ subdir-all-qemu-xen-dir subdir-install-q > > --extra-ldflags="-L$(XEN_ROOT)/tools/libxc \ > > -L$(XEN_ROOT)/tools/xenstore" \ > > --bindir=$(LIBEXEC) \ > > + --datadir=$(SHAREDIR)/xen/qemu-xen \ > > I think that $(SHAREDIR)/qemu-xen makes more senseOk, I will resubmit with this path. Olaf
Olaf Hering
2012-Mar-19 13:41 UTC
[PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
# HG changeset patch # User Olaf Hering <olaf@aepfle.de> # Date 1332164506 -3600 # Node ID 94066d2f6045e80dc5d2dce762d8966695b3f2a2 # Parent 4e1d091d10d83130842170cd61f1194e5459f2aa tools: specify datadir for qemu-xen build to fix firmware loading qemu-xen does currently not find the firmware files, such as vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix /usr/local. Use SHAREDIR/qemu-xen as directory so that it can coexist with qemu-traditional which is installed in SHAREDIR/xen/qemu. v2: - change datadir from SHAREDIR/xen/qemu-xen to SHAREDIR/qemu-xen Signed-off-by: Olaf Hering <olaf@aepfle.de> diff -r 4e1d091d10d8 -r 94066d2f6045 tools/Makefile --- a/tools/Makefile +++ b/tools/Makefile @@ -154,6 +154,7 @@ subdir-all-qemu-xen-dir subdir-install-q --extra-ldflags="-L$(XEN_ROOT)/tools/libxc \ -L$(XEN_ROOT)/tools/xenstore" \ --bindir=$(LIBEXEC) \ + --datadir=$(SHAREDIR)/qemu-xen \ --disable-kvm \ --python=$(PYTHON) \ $(IOEMU_CONFIGURE_CROSS); \
Stefano Stabellini
2012-Mar-19 15:18 UTC
Re: [PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
On Mon, 19 Mar 2012, Olaf Hering wrote:> # HG changeset patch > # User Olaf Hering <olaf@aepfle.de> > # Date 1332164506 -3600 > # Node ID 94066d2f6045e80dc5d2dce762d8966695b3f2a2 > # Parent 4e1d091d10d83130842170cd61f1194e5459f2aa > tools: specify datadir for qemu-xen build to fix firmware loading > > qemu-xen does currently not find the firmware files, such as > vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix > /usr/local. Use SHAREDIR/qemu-xen as directory so that it can coexist > with qemu-traditional which is installed in SHAREDIR/xen/qemu. > > v2: > - change datadir from SHAREDIR/xen/qemu-xen to SHAREDIR/qemu-xen > > Signed-off-by: Olaf Hering <olaf@aepfle.de>Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Ian Jackson
2012-Apr-03 14:30 UTC
Re: [PATCH] tools: specify datadir for qemu-xen build to fix firmware loading
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] tools: specify datadir
for qemu-xen build to fix firmware loading"):> On Mon, 19 Mar 2012, Olaf Hering wrote:
> > tools: specify datadir for qemu-xen build to fix firmware loading
...> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reasonably Related Threads
- [PATCH 0 of 1 v2] tools: honour --libdir when it is passed to ./configure
- [PATCH] x86/EFI: define and use EFI_DIR make variable, defaulting to /usr/lib64/efi
- [PATCH] tools/configure: add options to pass EXTRA_CLFAGS
- [PATCH v10 0/7] build upstream qemu and seabios by default
- [PATCH] libxl: pass debug flag down to libxl_domain_suspend