Xen devel - Jan 2012 - RFC PATCH: bring OpenBSD stdarg in line with FreeBSD one

Having an absolute path in a #include confuses distcc''s pump mode.
Since AFAICS OpenBSD''s stdarg handling uses the builtins, I think we
should just treat it like we do NetBSD.

I don''t have an OpenBSD box to test on, though. :(  Any OpenBSD
enthusiasts care to comment?

Tim.

diff --git a/xen/include/xen/stdarg.h b/xen/include/xen/stdarg.h
index 57e2c0e..cb870ac 100644
--- a/xen/include/xen/stdarg.h
+++ b/xen/include/xen/stdarg.h
@@ -1,9 +1,7 @@
 #ifndef __XEN_STDARG_H__
 #define __XEN_STDARG_H__
 
-#if defined(__OpenBSD__)
-#  include "/usr/include/stdarg.h"
-#elif defined (__NetBSD__)
+#if defined(__OpenBSD__) || defined(__NetBSD__)
    typedef __builtin_va_list va_list;
 #  define va_start(ap, last)    __builtin_stdarg_start((ap), (last))
 #  define va_end(ap)            __builtin_va_end(ap)

At 16:16 +0000 on 19 Jan (1326989786), Tim Deegan wrote:
> Having an absolute path in a #include confuses distcc''s pump mode.
> Since AFAICS OpenBSD''s stdarg handling uses the builtins, I think
we
> should just treat it like we do NetBSD.
> 
> I don''t have an OpenBSD box to test on, though. :(  Any OpenBSD
> enthusiasts care to comment?
No complaints, and the new header compiles on OpenBSD, so I''ve applied
it.

Cheers,

Tim.

On 01/26/12 16:45, Tim Deegan wrote:
> At 16:16 +0000 on 19 Jan (1326989786), Tim Deegan wrote:
>> Having an absolute path in a #include confuses distcc''s pump
mode.
>> Since AFAICS OpenBSD''s stdarg handling uses the builtins, I
think we
>> should just treat it like we do NetBSD.
>>
>> I don''t have an OpenBSD box to test on, though. :(  Any
OpenBSD
>> enthusiasts care to comment?
>
> No complaints, and the new header compiles on OpenBSD, so I''ve
applied it.
... the commit message does not match what the actually patch does.
You mixed up FreeBSD with NetBSD. :-)

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

At 11:09 +0100 on 27 Jan (1327662553), Christoph Egger
wrote:
> On 01/26/12 16:45, Tim Deegan wrote:
> >At 16:16 +0000 on 19 Jan (1326989786), Tim Deegan wrote:
> >>Having an absolute path in a #include confuses distcc''s
pump mode.
> >>Since AFAICS OpenBSD''s stdarg handling uses the builtins,
I think we
> >>should just treat it like we do NetBSD.
> >>
> >>I don''t have an OpenBSD box to test on, though. :(  Any
OpenBSD
> >>enthusiasts care to comment?
> >
> >No complaints, and the new header compiles on OpenBSD, so I''ve
applied it.
> 
> ... the commit message does not match what the actually patch does.
> You mixed up FreeBSD with NetBSD. :-)
Augh, so I have!

Tim.