Xen devel - Nov 2011 - [PATCH] Hypercall continuation cancelation in compat mode for XENMEM_get/set_pod_target.

If copy_to_guest failed in the compat code after a continuation as been
done in the native code we need to cancel it so we won''t reexecute the
hypercall but return from the hypercall with the appropriate error.

Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
---
 xen/arch/x86/domain.c           |   18 ++++++++++++++++++
 xen/arch/x86/x86_64/compat/mm.c |    4 ++++
 xen/include/xen/sched.h         |    1 +
 3 files changed, 23 insertions(+), 0 deletions(-)



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On 10.11.11 at 18:17, Jean Guyader
<jean.guyader@eu.citrix.com> wrote:
> If copy_to_guest failed in the compat code after a continuation as been
> done in the native code we need to cancel it so we won''t reexecute
the
> hypercall but return from the hypercall with the appropriate error.
> 
> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>

(But I''d like to be certain that Keir also took a look at this before
committing, not the least because this also should go into 4.1-testing.)
> ---
>  xen/arch/x86/domain.c           |   18 ++++++++++++++++++
>  xen/arch/x86/x86_64/compat/mm.c |    4 ++++
>  xen/include/xen/sched.h         |    1 +
>  3 files changed, 23 insertions(+), 0 deletions(-)



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 11/11/2011 08:38, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 10.11.11 at 18:17, Jean Guyader
<jean.guyader@eu.citrix.com> wrote:
> 
>> If copy_to_guest failed in the compat code after a continuation as been
>> done in the native code we need to cancel it so we won''t
reexecute the
>> hypercall but return from the hypercall with the appropriate error.
>> 
>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> (But I''d like to be certain that Keir also took a look at this
before
> committing, not the least because this also should go into 4.1-testing.)
Looks okay to me.

Acked-by: Keir Fraser <keir@xen.org>
>> ---
>>  xen/arch/x86/domain.c           |   18 ++++++++++++++++++
>>  xen/arch/x86/x86_64/compat/mm.c |    4 ++++
>>  xen/include/xen/sched.h         |    1 +
>>  3 files changed, 23 insertions(+), 0 deletions(-)
> 
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 10/11 05:17, Jean Guyader wrote:
> 
> If copy_to_guest failed in the compat code after a continuation as been
> done in the native code we need to cancel it so we won''t reexecute
the
> hypercall but return from the hypercall with the appropriate error.
> 
> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
Did that make it into 4.1?

Jean

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On 17.11.11 at 07:01, Jean Guyader
<jean.guyader@eu.citrix.com> wrote:
> On 10/11 05:17, Jean Guyader wrote:
>> 
>> If copy_to_guest failed in the compat code after a continuation as been
>> done in the native code we need to cancel it so we won''t
reexecute the
>> hypercall but return from the hypercall with the appropriate error.
>> 
>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
> 
> Did that make it into 4.1?
> 
> Jean
Not so far - Keir?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17/11/2011 06:01, "Jean Guyader" <jean.guyader@eu.citrix.com>
wrote:
> On 10/11 05:17, Jean Guyader wrote:
>> 
>> If copy_to_guest failed in the compat code after a continuation as been
>> done in the native code we need to cancel it so we won''t
reexecute the
>> hypercall but return from the hypercall with the appropriate error.
>> 
>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
> 
> Did that make it into 4.1?
Done.
> Jean
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel