Xen devel - Feb 2013 - [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen

tools/libxl: Disable useless empty floppy drive with
  qemu-xen

Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
---
  tools/libxl/libxl_dm.c |    3 +++
  1 file changed, 3 insertions(+)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 51f9914..c265618 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -406,6 +406,9 @@ static char ** 
libxl__build_device_model_args_new(libxl__gc *gc,
      if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
          int ioemu_nics = 0;

+        /* Disable useless empty floppy drive */
+        flexarray_vappend(dm_args, "-global",
"isa-fdc.driveA=", NULL);
+
          if (b_info->u.hvm.serial) {
              flexarray_vappend(dm_args, "-serial", 
b_info->u.hvm.serial, NULL);
          }
-- 
1.7.9.5

On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
>   qemu-xen
We used to get occasional requests to enable the floppy disk image to be
selected, but perhaps that need has passed (was something to do with
Windows sysprep IIRC).

Unfortunately the patch is whitespace damaged. ''git
send-email'' is your
friend...
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
> ---
>   tools/libxl/libxl_dm.c |    3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>           int ioemu_nics = 0;
> 
> +        /* Disable useless empty floppy drive */
> +        flexarray_vappend(dm_args, "-global",
"isa-fdc.driveA=", NULL);
> +
>           if (b_info->u.hvm.serial) {
>               flexarray_vappend(dm_args, "-serial", 
> b_info->u.hvm.serial, NULL);
>           }

On Tue, 5 Feb 2013, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
>   qemu-xen
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

>   tools/libxl/libxl_dm.c |    3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>           int ioemu_nics = 0;
> 
> +        /* Disable useless empty floppy drive */
> +        flexarray_vappend(dm_args, "-global",
"isa-fdc.driveA=", NULL);
> +
>           if (b_info->u.hvm.serial) {
>               flexarray_vappend(dm_args, "-serial", 
> b_info->u.hvm.serial, NULL);
>           }
> -- 
> 1.7.9.5
> 
>

On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
>   qemu-xen
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
> ---
>   tools/libxl/libxl_dm.c |    3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>           int ioemu_nics = 0;
> 
> +        /* Disable useless empty floppy drive */
> +        flexarray_vappend(dm_args, "-global",
"isa-fdc.driveA=", NULL);
> +
>           if (b_info->u.hvm.serial) {
>               flexarray_vappend(dm_args, "-serial", 
> b_info->u.hvm.serial, NULL);
I''m afraid this patch is whitespace corrupted. 

I strongly recommend that you investigate the use of git send-email.

Ian.

Il 15/02/2013 13:18, Ian Campbell ha scritto:
> On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
>> tools/libxl: Disable useless empty floppy drive with
>>    qemu-xen
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
>> ---
>>    tools/libxl/libxl_dm.c |    3 +++
>>    1 file changed, 3 insertions(+)
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 51f9914..c265618 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -406,6 +406,9 @@ static char **
>> libxl__build_device_model_args_new(libxl__gc *gc,
>>        if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>>            int ioemu_nics = 0;
>>
>> +        /* Disable useless empty floppy drive */
>> +        flexarray_vappend(dm_args, "-global",
"isa-fdc.driveA=", NULL);
>> +
>>            if (b_info->u.hvm.serial) {
>>                flexarray_vappend(dm_args, "-serial",
>> b_info->u.hvm.serial, NULL);
> I''m afraid this patch is whitespace corrupted.
>
> I strongly recommend that you investigate the use of git send-email.
>
> Ian.
>
I already resent with git send-email:
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00391.html