Hi all With 22277, I found try to migrate with option "--live" unsuccessful. It shows the error: Error: timed out Usage: xm migrate <Domain> <Host> But it works with 22267.Does "--live" not support any more in xen or just a regression? best regards yang _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Regression, probably due to either 22275 or 22277. Bisect to find out, and then report to the list cc Ian Campbell and Ian Jackson. -- Keir On 25/10/2010 04:52, "Zhang, Yang Z" <yang.z.zhang@intel.com> wrote:> Hi all > With 22277, I found try to migrate with option "--live" unsuccessful. It shows > the error: > Error: timed out > Usage: xm migrate <Domain> <Host> > > But it works with 22267.Does "--live" not support any more in xen or just a > regression? > > best regards > yang > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
It was introduced by 22275. best regards yang> -----Original Message----- > From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser > Sent: Monday, October 25, 2010 2:11 PM > To: Zhang, Yang Z; xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] migration fails with option "--live" > > Regression, probably due to either 22275 or 22277. Bisect to find out, and > then report to the list cc Ian Campbell and Ian Jackson. > > -- Keir > > On 25/10/2010 04:52, "Zhang, Yang Z" <yang.z.zhang@intel.com> wrote: > > > Hi all > > With 22277, I found try to migrate with option "--live" unsuccessful. It shows > > the error: > > Error: timed out > > Usage: xm migrate <Domain> <Host> > > > > But it works with 22267.Does "--live" not support any more in xen or just a > > regression? > > > > best regards > > yang > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote:> It was introduced by 22275.I''ll look into this today. Do you get any interesting messages in the logs? What sort of guest(s) are you testing, PV, HVM or PVHVM? Ian.> > best regards > yang > > > > -----Original Message----- > > From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser > > Sent: Monday, October 25, 2010 2:11 PM > > To: Zhang, Yang Z; xen-devel@lists.xensource.com > > Subject: Re: [Xen-devel] migration fails with option "--live" > > > > Regression, probably due to either 22275 or 22277. Bisect to find out, and > > then report to the list cc Ian Campbell and Ian Jackson. > > > > -- Keir > > > > On 25/10/2010 04:52, "Zhang, Yang Z" <yang.z.zhang@intel.com> wrote: > > > > > Hi all > > > With 22277, I found try to migrate with option "--live" unsuccessful. It shows > > > the error: > > > Error: timed out > > > Usage: xm migrate <Domain> <Host> > > > > > > But it works with 22267.Does "--live" not support any more in xen or just a > > > regression? > > > > > > best regards > > > yang > > > > > > > > > _______________________________________________ > > > Xen-devel mailing list > > > Xen-devel@lists.xensource.com > > > http://lists.xensource.com/xen-devel > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> -----Original Message----- > From: Ian Campbell [mailto:Ian.Campbell@eu.citrix.com] > Sent: Monday, October 25, 2010 3:38 PM > To: Zhang, Yang Z > Cc: Keir Fraser; xen-devel@lists.xensource.com; Ian Jackson > Subject: RE: [Xen-devel] migration fails with option "--live" > > On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote: > > It was introduced by 22275. > > I''ll look into this today. > > Do you get any interesting messages in the logs? > > What sort of guest(s) are you testing, PV, HVM or PVHVM?HVM. There are some error in xend.log: [2010-10-25 23:37:53 14236] INFO (XendCheckpoint:416) xc_save: failed to get the suspend evtchn port [2010-10-25 23:37:53 14236] INFO (XendCheckpoint:416) [2010-10-25 23:37:53 14236] INFO (XendCheckpoint:416) xc: error: Couldn''t enable qemu log-dirty mode (errno 2) (2 = No such file or directory): Internal error [2010-10-25 23:37:53 14236] ERROR (XendCheckpoint:178) Save failed on domain vCPL_LM_40_1288002025 (8) - resuming. Traceback (most recent call last): File "usr/lib64/python2.4/site-packages/xen/xend/XendCheckpoint.py", line 146, in save forkHelper(cmd, fd, saveInputHandler, False) File "usr/lib64/python2.4/site-packages/xen/xend/XendCheckpoint.py", line 404, in forkHelper raise XendError("%s failed" % string.join(cmd)) XendError: /usr/lib64/xen/bin/xc_save 30 8 0 0 5 failed [2010-10-25 23:37:53 14236] DEBUG (XendDomainInfo:3135) XendDomainInfo.resumeDomain(8) [2010-10-25 23:37:53 14236] DEBUG (XendDomainInfo:2498) XendDomainInfo.constructDomain [2010-10-25 23:37:53 14236] DEBUG (balloon:187) Balloon: 11075848 KiB free; need 16384; done. [2010-10-25 23:37:53 14236] DEBUG (XendDomain:476) Adding Domain: 9 [2010-10-25 23:37:53 14236] WARNING (XendDomainInfo:506) Cannot restore CPU affinity Check the attachment to see the details of xend log and qemu log. best regards yang> Ian. > > > > > best regards > > yang > > > > > > > -----Original Message----- > > > From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser > > > Sent: Monday, October 25, 2010 2:11 PM > > > To: Zhang, Yang Z; xen-devel@lists.xensource.com > > > Subject: Re: [Xen-devel] migration fails with option "--live" > > > > > > Regression, probably due to either 22275 or 22277. Bisect to find out, and > > > then report to the list cc Ian Campbell and Ian Jackson. > > > > > > -- Keir > > > > > > On 25/10/2010 04:52, "Zhang, Yang Z" <yang.z.zhang@intel.com> wrote: > > > > > > > Hi all > > > > With 22277, I found try to migrate with option "--live" unsuccessful. It > shows > > > > the error: > > > > Error: timed out > > > > Usage: xm migrate <Domain> <Host> > > > > > > > > But it works with 22267.Does "--live" not support any more in xen or just a > > > > regression? > > > > > > > > best regards > > > > yang > > > > > > > > > > > > _______________________________________________ > > > > Xen-devel mailing list > > > > Xen-devel@lists.xensource.com > > > > http://lists.xensource.com/xen-devel > > > > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote:> It was introduced by 22275.Simple thinko on my part, thanks for reporting. 8<-------- # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1288002211 -3600 # Node ID 3b832cf7c0f4e0c232c8d49be86fd86894f280e3 # Parent 3f41a2e6b6598df859df64966b39a0d0f6ccad03 libxc: correct xc_save utility''s switch_qemu_logdirty callback return value The callback return convention follows xc_domain_save and therefore should return 1 on success. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 3f41a2e6b659 -r 3b832cf7c0f4 tools/xcutils/xc_save.c --- a/tools/xcutils/xc_save.c Fri Oct 22 10:27:01 2010 +0100 +++ b/tools/xcutils/xc_save.c Mon Oct 25 11:23:31 2010 +0100 @@ -160,7 +160,7 @@ static int switch_qemu_logdirty(int domi free(cmd_str); free(ret_str); - return 0; + return 1; } int _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2010-10-25 at 11:24 +0100, Ian Campbell wrote:> On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote: > > It was introduced by 22275. > > Simple thinko on my part, thanks for reporting. > > 8<-------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1288002211 -3600 > # Node ID 3b832cf7c0f4e0c232c8d49be86fd86894f280e3 > # Parent 3f41a2e6b6598df859df64966b39a0d0f6ccad03 > libxc: correct xc_save utility''s switch_qemu_logdirty callback return value > > The callback return convention follows xc_domain_save and therefore > should return 1 on success.Bah, double confused myself. xc_domain_save returns 0 on success and >0 on error and the callbacks should do the same. Therefore the bug is in xc_domain_save where it checks the result of the callback... Will try fixing again after a little testing... Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2010-10-25 at 11:59 +0100, Ian Campbell wrote:> On Mon, 2010-10-25 at 11:24 +0100, Ian Campbell wrote: > > On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote: > > > It was introduced by 22275. > > > > Simple thinko on my part, thanks for reporting. > > > > 8<-------- > > > > # HG changeset patch > > # User Ian Campbell <ian.campbell@citrix.com> > > # Date 1288002211 -3600 > > # Node ID 3b832cf7c0f4e0c232c8d49be86fd86894f280e3 > > # Parent 3f41a2e6b6598df859df64966b39a0d0f6ccad03 > > libxc: correct xc_save utility''s switch_qemu_logdirty callback return value > > > > The callback return convention follows xc_domain_save and therefore > > should return 1 on success. > > Bah, double confused myself. xc_domain_save returns 0 on success and >0 > on error and the callbacks should do the same. Therefore the bug is in > xc_domain_save where it checks the result of the callback... > > Will try fixing again after a little testing...Lets try this one. Works under xend, xl migrate seems broken for HVM domains both before and after 22275:e95dc0eb152d. I''ll investigate that one separately. # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1288009016 -3600 # Node ID 61188eb58d6de7607e1a497402eacd987162661a # Parent 3dae6dc75fd268156b27833e79d88b647736dce9 libxc: correct handling of switch_qemu_logdirty callback return value The callback return convention follows xc_domain_save and therefore returns 0 on success and >0 on error, correct the check accordingly. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 3dae6dc75fd2 -r 61188eb58d6d tools/libxc/xc_domain_save.c --- a/tools/libxc/xc_domain_save.c Mon Oct 25 13:16:56 2010 +0100 +++ b/tools/libxc/xc_domain_save.c Mon Oct 25 13:16:56 2010 +0100 @@ -1015,7 +1015,7 @@ int xc_domain_save(xc_interface *xch, in } /* Enable qemu-dm logging dirty pages to xen */ - if ( hvm && !callbacks->switch_qemu_logdirty(dom, 1, callbacks->data) ) + if ( hvm && callbacks->switch_qemu_logdirty(dom, 1, callbacks->data) ) { PERROR("Couldn''t enable qemu log-dirty mode (errno %d)", errno); goto out; @@ -1879,7 +1879,7 @@ int xc_domain_save(xc_interface *xch, in XEN_DOMCTL_SHADOW_OP_OFF, NULL, 0, NULL, 0, NULL) < 0 ) DPRINTF("Warning - couldn''t disable shadow mode"); - if ( hvm && !callbacks->switch_qemu_logdirty(dom, 0, callbacks->data) ) + if ( hvm && callbacks->switch_qemu_logdirty(dom, 0, callbacks->data) ) DPRINTF("Warning - couldn''t disable qemu log-dirty mode"); } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell writes ("RE: [Xen-devel] migration fails with option
"--live""):> libxc: correct handling of switch_qemu_logdirty callback return value
>
> The callback return convention follows xc_domain_save and therefore
> returns 0 on success and >0 on error, correct the check accordingly.
I have applied this one.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel