# HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1286898427 -3600 # Node ID 811dfe7ea7a79e5cb236c8c1fb81d47de22787d0 # Parent 7c7141f655fd2c561dac5589a93f21aacc2562f1 xl: correct migration_domname_r 22154:ed8019e672c6 causes migration_domname_r to be initialised as d_config.c_info.name + "--incoming" immediately after setting d_config.c_info.name. The intention appears to have been to set it to common_domname + "--incoming" so do so. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 7c7141f655fd -r 811dfe7ea7a7 tools/libxl/xl_cmdimpl.c --- a/tools/libxl/xl_cmdimpl.c Tue Oct 12 16:37:17 2010 +0100 +++ b/tools/libxl/xl_cmdimpl.c Tue Oct 12 16:47:07 2010 +0100 @@ -1562,7 +1562,7 @@ static int create_domain(struct domain_c d_config.c_info.name = 0; /* steals allocation from config */ if (asprintf(&d_config.c_info.name, - "%s--incoming", d_config.c_info.name) < 0) { + "%s--incoming", common_domname) < 0) { fprintf(stderr, "Failed to allocate memory in asprintf\n"); exit(1); } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2010-Oct-13 10:37 UTC
Re: [Xen-devel] [PATCH] xl: correct migration_domname_r
On Tue, 12 Oct 2010, Ian Campbell wrote:> # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1286898427 -3600 > # Node ID 811dfe7ea7a79e5cb236c8c1fb81d47de22787d0 > # Parent 7c7141f655fd2c561dac5589a93f21aacc2562f1 > xl: correct migration_domname_r > > 22154:ed8019e672c6 causes migration_domname_r to be initialised as > d_config.c_info.name + "--incoming" immediately after setting > d_config.c_info.name. The intention appears to have been to set it to > common_domname + "--incoming" so do so. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>applied, thanks _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel