Xen devel - Sep 2010 - [PATCH] Make NIC model fallback to default when specified model is not supported

Hi,
this is the patch to introduce a NIC model fallback to default when model
specified is not supported. It''s been tested on x86_64 host with
current
version of qemu-dm using the RHEL-5 i386 virtual machine and by trying to
setup the invalid (unsupported) model of NIC device. Also, the new constant
in the net.h called the DEFAULT_NIC_MODEL has been introduced to be able to
change the default NIC model easily. This variable is being used to set
the default NIC model when necessary.

It''s been tested by running a guest with NIC model set to be
"eee" which
is not supported and when the guest was started I tried to issue
"lspci"
to list all the PCI devices and there was Realtek RTL-8239 (AS) card
which is basically the ne2k_pci card (default for Xen-4.1 qemu-dm) so
the old default has been preserved and it''s being used as a fallback.

Michal

Signed-off-by: Michal Novotny<minovotn@redhat.com>

-- 
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 09/20/2010 12:21 PM, Michal Novotny wrote:
> Hi,
> this is the patch to introduce a NIC model fallback to default when model
> specified is not supported. It''s been tested on x86_64 host with
current
> version of qemu-dm using the RHEL-5 i386 virtual machine and by trying to
> setup the invalid (unsupported) model of NIC device. Also, the new constant
> in the net.h called the DEFAULT_NIC_MODEL has been introduced to be able to
> change the default NIC model easily. This variable is being used to set
> the default NIC model when necessary.
>
> It''s been tested by running a guest with NIC model set to be
"eee" which
> is not supported and when the guest was started I tried to issue
"lspci"
> to list all the PCI devices and there was Realtek RTL-8239 (AS) card
> which is basically the ne2k_pci card (default for Xen-4.1 qemu-dm) so
> the old default has been preserved and it''s being used as a
fallback.
I don''t think qemu-dm and upstream QEMU should diverge again, so this 
patch does not sound like a good thing for Xen''s ioemu codebase.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Michal Novotny writes ("[Xen-devel] [PATCH] Make NIC model fallback to
default when specified model is not supported"):
> this is the patch to introduce a NIC model fallback to default when model
> specified is not supported.
This functionality should be done in the toolstack (libxl, xend) not
in qemu-dm.  I see that currently it''s done in xl_cmdimpl.c (ie, in
xl) which I think is wrong.  These default settings should be in
libxl.

But touching qemu for this is definitely wrong.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel