Olaf Hering
2010-Sep-09 13:37 UTC
[Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking
Hello, the comments in hap_enable_vram_tracking() and hap_clean_vram_tracking() say the pages will be set to read-only, but it passes p2m_ram_rw instead of p2m_ram_ro to p2m_change_type(). Bug or feature? Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Sep-09 13:48 UTC
Re: [Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking
At 14:37 +0100 on 09 Sep (1284043066), Olaf Hering wrote:> > Hello, > > the comments in hap_enable_vram_tracking() and hap_clean_vram_tracking() > say the pages will be set to read-only, but it passes p2m_ram_rw instead > of p2m_ram_ro to p2m_change_type(). > > Bug or feature?Neither. :) It''s changing _from_ type p2m_ram_rw to type p2m_ram_logdirty (which is read-only until the next write, when it reverts to p2m_ram_rw and marks the page dirty). Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel