Hi, 22066:eccfdeb41b80 replaced tools/libxc/ia64/aclinux.h with xen/include/acpi/platform/aclinux.h. In fact, the former differs from the latter: the former supports non-kernel codes, but the latter does not support it because 17814:9af7a535225f removed it. Thus tools cannot be built on ia64. This patch adds #ifdef __XEN__ and copies non-kernel support codes in the former. Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ping? This patch is still required for ia64 tools. Best regards, -- KUWAMURA Shin''ya On <20100902.134350.71558960.kuwa@jp.fujitsu.com> "KUWAMURA Shin''ya" wrote:> > Hi, > > 22066:eccfdeb41b80 replaced tools/libxc/ia64/aclinux.h with > xen/include/acpi/platform/aclinux.h. > > In fact, the former differs from the latter: the former supports > non-kernel codes, but the latter does not support it because > 17814:9af7a535225f removed it. > > Thus tools cannot be built on ia64. > > This patch adds #ifdef __XEN__ and copies non-kernel support codes in > the former. > > Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> > -- > KUWAMURA Shin''ya-- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 29/10/2010 08:39, "KUWAMURA Shin''ya" <kuwa@jp.fujitsu.com> wrote:> Ping? > > This patch is still required for ia64 tools. > > Best regards,I think it would ne neater to have your own tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from Xen''s acenv.h (e.g., dependent on __XEN_TOOLS__). Or revert the bits of c/s 22066 that broke the ia64 build in the first place -- possibly the changes were based on a false assumption? Cc''ing the author of that patch, Ian Campbell. In any case, ifdef''ing the bulk of aclinux.h is just gross, I don''t like that fix. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, 2010-10-29 at 08:55 +0100, Keir Fraser wrote:> On 29/10/2010 08:39, "KUWAMURA Shin''ya" <kuwa@jp.fujitsu.com> wrote: > > > Ping? > > > > This patch is still required for ia64 tools. > > > > Best regards, > > I think it would ne neater to have your own > tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from > Xen''s acenv.h (e.g., dependent on __XEN_TOOLS__). Or revert the bits of c/s > 22066 that broke the ia64 build in the first place -- possibly the changes > were based on a false assumption?Yeah, I thought it was unused. I may have confused it with tools/libxc/ia64/acpi/platform/aclinux.h which is in fact just a symlink to xen/include/acpi/platform/aclinux.h. Note that tools/libxc is now licensed as LGPL so before simply reinstating the old file it probably needs to be confirmed that it is ok to license that way. (that said the contents of the file don''t seem particularly exciting, a cleanroom rewrite based on compiling and observing the errors would be pretty trivial)> Cc''ing the author of that patch, Ian > Campbell. In any case, ifdef''ing the bulk of aclinux.h is just gross, I > don''t like that fix.Why do we even need what appears to be a simplistic OS abstraction layer in the tools first place? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi Keir and Ian,>>>>> On Fri, 29 Oct 2010 08:55:31 +0100 >>>>> keir@xen.org(Keir Fraser) said: > > I think it would ne neater to have your own > tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from > Xen''s acenv.h (e.g., dependent on __XEN_TOOLS__).I created a patch for Keir''s first advice. This patch introduces ac_ia64_tools.h and it only defines identifiers in order to avoid compilation errors. Because all identifiers can be easily led from the error message, it is trivial. Any comments? Best regards, -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 01/11/2010 08:39, "KUWAMURA Shin''ya" <kuwa@jp.fujitsu.com> wrote:> Hi Keir and Ian, > >>>>>> On Fri, 29 Oct 2010 08:55:31 +0100 >>>>>> keir@xen.org(Keir Fraser) said: >> >> I think it would ne neater to have your own >> tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from >> Xen''s acenv.h (e.g., dependent on __XEN_TOOLS__). > > I created a patch for Keir''s first advice. > > This patch introduces ac_ia64_tools.h and it only defines identifiers > in order to avoid compilation errors. > > Because all identifiers can be easily led from the error message, > it is trivial. > > Any comments?I''ll apply this if IanC finds it acceptable. -- Keir> Best regards,_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2010-11-01 at 09:21 +0000, Keir Fraser wrote:> On 01/11/2010 08:39, "KUWAMURA Shin''ya" <kuwa@jp.fujitsu.com> wrote: > > > Hi Keir and Ian, > > > >>>>>> On Fri, 29 Oct 2010 08:55:31 +0100 > >>>>>> keir@xen.org(Keir Fraser) said: > >> > >> I think it would ne neater to have your own > >> tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from > >> Xen''s acenv.h (e.g., dependent on __XEN_TOOLS__). > > > > I created a patch for Keir''s first advice. > > > > This patch introduces ac_ia64_tools.h and it only defines identifiers > > in order to avoid compilation errors. > > > > Because all identifiers can be easily led from the error message, > > it is trivial. > > > > Any comments? > > I''ll apply this if IanC finds it acceptable.Subject to the addition of a license boiler plate at the top of ltools/libxc/ia64/ac_ia64_tools.h, either the LGPLv2 one used through out libxc or something compatible, it is fine with me. Ian.> > -- Keir > > > Best regards, > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 01/11/2010 09:28, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:>> I''ll apply this if IanC finds it acceptable. > > Subject to the addition of a license boiler plate at the top of > ltools/libxc/ia64/ac_ia64_tools.h, either the LGPLv2 one used through > out libxc or something compatible, it is fine with me.Kuwamura, Please fix that and then I will apply the patch. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi,>>>>> On Mon, 01 Nov 2010 09:48:41 +0000 >>>>> keir@xen.org(Keir Fraser) said: > > On 01/11/2010 09:28, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote: > > >> I''ll apply this if IanC finds it acceptable. > > > > Subject to the addition of a license boiler plate at the top of > > ltools/libxc/ia64/ac_ia64_tools.h, either the LGPLv2 one used through > > out libxc or something compatible, it is fine with me. > > Please fix that and then I will apply the patch.I added LGPLv2 license boiler plate. Best regards, -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel