Gianni Tedesco
2010-Jul-26 17:24 UTC
[Xen-devel] [PATCH]: xl, fix segfault when detaching non-existant disk
Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
diff -r ac7e4c6ec6c7 tools/libxl/libxl_utils.c
--- a/tools/libxl/libxl_utils.c Fri Jul 23 19:23:49 2010 +0100
+++ b/tools/libxl/libxl_utils.c Mon Jul 26 18:23:42 2010 +0100
@@ -451,6 +451,8 @@ int libxl_devid_to_device_disk(struct li
}
val = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx,
"%s/backend-id", diskpath));
+ if (!val)
+ return ERROR_FAIL;
disk->backend_domid = strtoul(val, NULL, 10);
disk->domid = domid;
be_path = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx,
"%s/backend", diskpath));
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Jackson
2010-Jul-27 15:21 UTC
[Xen-devel] Re: [PATCH]: xl, fix segfault when detaching non-existant disk
Gianni Tedesco (3P) writes ("[PATCH]: xl, fix segfault when detaching
non-existant disk"):> val = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx,
"%s/backend-id", diskpath));
> + if (!val)
> + return ERROR_FAIL;
This is fine as far as it goes, and I''ll apply it, but would you like
to do the same for all the other unchecked libxl_xs_read calls ? :-)
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Gianni Tedesco
2010-Jul-27 16:10 UTC
[Xen-devel] Re: [PATCH]: xl, fix segfault when detaching non-existant disk
On Tue, 2010-07-27 at 16:21 +0100, Ian Jackson wrote:> Gianni Tedesco (3P) writes ("[PATCH]: xl, fix segfault when detaching non-existant disk"): > > val = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/backend-id", diskpath)); > > + if (!val) > > + return ERROR_FAIL; > > This is fine as far as it goes, and I''ll apply it, but would you like > to do the same for all the other unchecked libxl_xs_read calls ? :-)It''s a gigantic piece of work, along with sorting out various memory leaks. It is on my TODO list :) Gianni _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel