Creates and assigns a shared memory page and event channel for the console ring buffer. The Windows PV drivers can use this console ring buffer and event channel to pass on debug output. Signed-off-by: Owen Smith <owen.smith@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 19/07/2010 14:51, "Owen Smith" <owen.smith@citrix.com> wrote:> Creates and assigns a shared memory page and event channel for the console > ring buffer. > The Windows PV drivers can use this console ring buffer and event channel to > pass on debug output. > > Signed-off-by: Owen Smith <owen.smith@citrix.com>I ack this conceptually at least. I leave it to the tools maintainers to comment on the bulk of the implementation -- I notice some hard versus soft indentation issues for example. Ian: you can check the whole lot of this patch into your tree when you''re happy with it, even though it touches a hypervisor header file. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
At 14:51 +0100 on 19 Jul (1279551066), Owen Smith wrote:> diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c > --- a/tools/libxc/xc_domain_save.c > +++ b/tools/libxc/xc_domain_save.c > @@ -915,7 +915,7 @@ > uint8_t *hvm_buf = NULL; > > /* HVM: magic frames for ioreqs and xenstore comms. */ > - uint64_t magic_pfns[3]; /* ioreq_pfn, bufioreq_pfn, store_pfn */ > + uint64_t magic_pfns[4]; /* ioreq_pfn, bufioreq_pfn, store_pfn, console_pfn */This breaks save-file compatibility with older tools. Look at how HVM_PARAM_IDENT_PT and HVM_PARAM_VM86_TSS are handled for a better model of how to add your new param to the save format. Cheers, Tim -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel