Vincent Hanquez
2010-Jul-13 10:11 UTC
[Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler
The script doesn''t check anything if the $OS is not linux, and just print a warning if the compiler is missing. Signed-off-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com> --- tools/check/check_ocaml | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100755 tools/check/check_ocaml _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2010-Jul-13 18:12 UTC
Re: [Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler
Vincent Hanquez writes ("[Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler"):> The script doesn''t check anything if the $OS is not linux, and just print a > warning if the compiler is missing.I don''t understand the rationale behind only warning about missing ocaml compilers on Linux. Either there is nothing wrong with not having ocaml and using all the C tools (specifically, C xenstore), in which case it arguably shouldn''t produce a warning; or the future is supposedly ocaml and then we should warn everywhere. Of course the latter situation would imply that ocaml can in practice be found on non-Linux dom0''s without too much pain. Is that true ? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2010-Jul-14 10:33 UTC
Re: [Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler
On 13/07/10 19:12, Ian Jackson wrote:> Vincent Hanquez writes ("[Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler"): > >> The script doesn''t check anything if the $OS is not linux, and just print a >> warning if the compiler is missing. >> > I don''t understand the rationale behind only warning about missing > ocaml compilers on Linux. >Unless oxenstored get some portability efforts, warning on system that can''t use it anyway is just annoying for no gain. On system that can use it (just linux), we want to push people using it. -- Vincent _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel