Tim Deegan
2010-Jul-09 13:30 UTC
[Xen-devel] [PATCH 0 of 2] New HVMOPs for PV-on-HVM drivers
These patches add two HVM operations that can be used by the XCP PV drivers. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Jul-09 13:30 UTC
[Xen-devel] [PATCH 1 of 2] Add a new HVMOP which allows an HVM guest to get the current
Xen absolute system time, so that it can use SCHEDOP_poll in a sensible fashion. HVM PV drivers can''t use the normal PV clock because they might have TSC offsets that hey don''t know about. Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Jul-09 13:30 UTC
[Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Jul-09 14:44 UTC
Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
>>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@citrix.com> wrote: >+ if ( tr.extra_bytes > 28 || tr.event >= 0x1000 )Couldn''t you use TRACE_EXTRA_MAX * sizeof(u32) instead of the literal 28? The literal 0x1000 also doesn''t look nice - I''m no sure though whether this really is (1 << TRC_SUBCLS_SHIFT). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Jul-09 15:07 UTC
Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
At 15:44 +0100 on 09 Jul (1278690260), Jan Beulich wrote:> >>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@citrix.com> wrote: > >+ if ( tr.extra_bytes > 28 || tr.event >= 0x1000 ) > > Couldn''t you use TRACE_EXTRA_MAX * sizeof(u32) instead of the > literal 28?Indeed I should.> The literal 0x1000 also doesn''t look nice - I''m no sure though > whether this really is (1 << TRC_SUBCLS_SHIFT).Yes it is (the guest''s not allowed to define the class or subclass of the trace entry). How about the attached patch instead? Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Jul-09 16:02 UTC
Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
>>> On 09.07.10 at 17:07, Tim Deegan <Tim.Deegan@citrix.com> wrote: > At 15:44 +0100 on 09 Jul (1278690260), Jan Beulich wrote: >> >>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@citrix.com> wrote: >> >+ if ( tr.extra_bytes > 28 || tr.event >= 0x1000 ) >> >> Couldn''t you use TRACE_EXTRA_MAX * sizeof(u32) instead of the >> literal 28? > > Indeed I should. > >> The literal 0x1000 also doesn''t look nice - I''m no sure though >> whether this really is (1 << TRC_SUBCLS_SHIFT). > > Yes it is (the guest''s not allowed to define the class or subclass of > the trace entry). How about the attached patch instead?Great, thanks! Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel