Tim Deegan
2010-Jul-08 10:03 UTC
[Xen-devel] [PATCH] replace BUG() with a console warning in the MCE handler
Replace BUG() with a console warning in the MCE handler.
If the hardware reports corrected errors that we didn''t see through the
status MSRs, complain on the console but don''t BUG() the machine.
Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com>
diff -r e316ad18de3c xen/arch/x86/cpu/mcheck/amd_nonfatal.c
--- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c Wed Jul 07 11:27:36 2010 +0100
+++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c Thu Jul 08 11:02:52 2010 +0100
@@ -152,14 +152,19 @@
/* HW does not count *all* kinds of correctable errors.
* Thus it is possible, that the polling routine finds an
- * correctable error even if the HW reports nothing.
- * However, the other way around is not possible (= BUG).
- */
+ * correctable error even if the HW reports nothing. */
if (counter > 0) {
/* HW reported correctable errors,
* the polling routine did not find...
*/
- BUG_ON(adjust == 0);
+ if (adjust == 0) {
+ printk("CPU counter reports %"PRIu32
+ " correctable hardware error%s that %s"
+ " not reported by the status MSRs\n",
+ counter,
+ (counter == 1 ? "" : "s"),
+ (counter == 1 ? "was" : "were"));
+ }
/* subtract 1 to not double count the error
* from the polling service routine */
adjust += (counter - 1);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel