Hi! Attached patch makes x86 oprofile code use rdmsrl/wrmsrl Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
How many more of these patches do you have up your sleeve? -- Keir On 29/06/2010 16:47, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi! > > Attached patch makes x86 oprofile code use rdmsrl/wrmsrl > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2010-Jun-30 10:12 UTC
Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl
On Tuesday 29 June 2010 18:02:54 Keir Fraser wrote:> How many more of these patches do you have up your sleeve?Depends on how small/large the chunks should/may be. My intention is to remove duplicated rdmsr/wrmsr functions and make rdmsr usable as a real C function. The large part of changes are the bit-operations surrounding the rdmsr/wrmsr code lines. The sent patches replace rdmsr/wrmsr by rdmsrl/wrmsrl step by step. When this is done, rdmsr/wrmsr can be killed. Christoph> -- Keir > > On 29/06/2010 16:47, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi! > > > > Attached patch makes x86 oprofile code use rdmsrl/wrmsrl > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 30/06/2010 11:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> On Tuesday 29 June 2010 18:02:54 Keir Fraser wrote: >> How many more of these patches do you have up your sleeve? > > Depends on how small/large the chunks should/may be. > My intention is to remove duplicated rdmsr/wrmsr functions > and make rdmsr usable as a real C function.It''s a lot of effort for questionable value isn''t it. And many of your patches so far have contained bugs, and in some cases decreased code readability by needing to manually merge/split values to be able to make use of rdmsrl/wrmsrl, so it''s not like it''s even strictly improving the code. Frankly, it smells like busy work. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2010-Jun-30 11:02 UTC
Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl
On Wednesday 30 June 2010 12:19:09 Keir Fraser wrote:> On 30/06/2010 11:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > On Tuesday 29 June 2010 18:02:54 Keir Fraser wrote: > >> How many more of these patches do you have up your sleeve? > > > > Depends on how small/large the chunks should/may be. > > My intention is to remove duplicated rdmsr/wrmsr functions > > and make rdmsr usable as a real C function. > > It''s a lot of effort for questionable value isn''t it. And many of your > patches so far have contained bugs, and in some cases decreased code > readability by needing to manually merge/split values to be able to make > use of rdmsrl/wrmsrl, so it''s not like it''s even strictly improving the > code. Frankly, it smells like busy work.Yes, you''re right. Work like this is not funny and error-prone (you can look over it many times, test it many times and still bugs sit in there), hence the high number of small patches so that other people look at it and make bisecting easier. Whoever is doing such work always risks to get the head chopped off for the breakages. The parts decreasing code readability should actually be rewritten but this is beyond of my intention. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Joerg Roedel
2010-Jun-30 14:29 UTC
Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl
On Wed, Jun 30, 2010 at 01:02:50PM +0200, Christoph Egger wrote:> The parts decreasing code readability should actually be rewritten > but this is beyond of my intention.That''s interesting. What is your intention then? Joerg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2010-Jun-30 14:34 UTC
Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl
On Wednesday 30 June 2010 16:29:44 Joerg Roedel wrote:> On Wed, Jun 30, 2010 at 01:02:50PM +0200, Christoph Egger wrote: > > The parts decreasing code readability should actually be rewritten > > but this is beyond of my intention. > > That''s interesting. What is your intention then?As explained in an earlier mail, I want to get rid of the redundant rdmsr/wrmsr functions. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Joerg Roedel
2010-Jun-30 14:43 UTC
Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl
On Wed, Jun 30, 2010 at 04:34:43PM +0200, Christoph Egger wrote:> As explained in an earlier mail, I want to get rid of the > redundant rdmsr/wrmsr functions.What''s the point of that if you decrease the code readability? Joerg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel