Hi! Attached patch moves vmcb dump function into its own svm debug files. Add svm_vmcb_isvalid() to svm code to validate the vmcb. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> P.S.: svm_vmcb_isvalid() is extracted from my nested virtualization patches. -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 23/06/2010 13:49, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> Attached patch moves vmcb dump function into > its own svm debug files. > Add svm_vmcb_isvalid() to svm code to validate > the vmcb.I won''t take patches to add things that aren''t used. Unless they are used later in the same patch series, all posted with intention to be applied at the same time. Otherwise the function is dead code, and I love to delete dead code. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wednesday 23 June 2010 15:48:28 Keir Fraser wrote:> On 23/06/2010 13:49, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Attached patch moves vmcb dump function into > > its own svm debug files. > > Add svm_vmcb_isvalid() to svm code to validate > > the vmcb. > > I won''t take patches to add things that aren''t used. Unless they are used > later in the same patch series,Yes, that is the case. It will be used in the nested virtualization patch series. Do you prefer me to resend it as part of the patch series?> all posted with intention to be applied at > the same time. Otherwise the function is dead code, and I love to delete > dead code.Me, too. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 24/06/2010 11:33, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> I won''t take patches to add things that aren''t used. Unless they are used >> later in the same patch series, > > Yes, that is the case. It will be used in the nested virtualization patch > series. Do you prefer me to resend it as part of the patch series?Yes indeed. K. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel