Vincent Hanquez
2010-Jun-22 09:26 UTC
[Xen-devel] [PATCH 0/3] libflask merging in libxenctrl
The following patch series fold libflask into libxenctrl. The flask library is small, and putting everything in libxenctrl make relying on flask functionalities in libxl easier. libflask is left for compatibility purpose, but should be considered deprecated, and remove in the near future. all flask_ symbols are now xc_flask_ symbols in libxenctrl. also remove some code duplication in the add_ and del_ calls. Vincent Hanquez (3): merge libflask into libxenctrl remove some duplicated code by having helper add/del functions add flask capabilities in python xc bindings tools/libxc/xc_flask.c | 357 +++++++++++++++++++++++++++++++++++++ tools/libxc/xenctrl.h | 26 +++ tools/python/xen/lowlevel/xc/xc.c | 251 ++++++++++++++++++++++++++ 3 files changed, 634 insertions(+), 0 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2010-Jun-22 09:26 UTC
[Xen-devel] [PATCH 1/3] merge libflask into libxenctrl
Signed-off-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com> --- tools/libxc/xc_flask.c | 496 ++++++++++++++++++++++++++++++++++++++++++++++++ tools/libxc/xenctrl.h | 26 +++ 2 files changed, 522 insertions(+), 0 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2010-Jun-22 09:26 UTC
[Xen-devel] [PATCH 2/3] remove some duplicated code by having helper add/del functions
Signed-off-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com> --- tools/libxc/xc_flask.c | 227 +++++++++-------------------------------------- 1 files changed, 44 insertions(+), 183 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2010-Jun-22 09:26 UTC
[Xen-devel] [PATCH 3/3] add flask capabilities in python xc bindings
Signed-off-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com> --- tools/python/xen/lowlevel/xc/xc.c | 251 +++++++++++++++++++++++++++++++++++++ 1 files changed, 251 insertions(+), 0 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Jun-22 09:50 UTC
Re: [Xen-devel] [PATCH 0/3] libflask merging in libxenctrl
At 10:26 +0100 on 22 Jun (1277202415), Vincent Hanquez wrote:> The following patch series fold libflask into libxenctrl. > > The flask library is small, and putting everything in libxenctrl make > relying on flask functionalities in libxl easier.That doesn''t sound like a good reason to duplicate a library to me. If libxl needs flask functions it should link against them. Are you volunteering to maintain a fork of a security library? Tim.> libflask is left for compatibility purpose, but should be considered > deprecated, and remove in the near future. all flask_ symbols are now > xc_flask_ symbols in libxenctrl. > > also remove some code duplication in the add_ and del_ calls. > > Vincent Hanquez (3): > merge libflask into libxenctrl > remove some duplicated code by having helper add/del functions > add flask capabilities in python xc bindings > > tools/libxc/xc_flask.c | 357 +++++++++++++++++++++++++++++++++++++ > tools/libxc/xenctrl.h | 26 +++ > tools/python/xen/lowlevel/xc/xc.c | 251 ++++++++++++++++++++++++++ > 3 files changed, 634 insertions(+), 0 deletions(-) >Content-Description: ATT00001..txt> _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Jun-22 10:04 UTC
Re: [Xen-devel] [PATCH 0/3] libflask merging in libxenctrl
At 10:50 +0100 on 22 Jun (1277203803), Tim Deegan wrote:> At 10:26 +0100 on 22 Jun (1277202415), Vincent Hanquez wrote: > > The following patch series fold libflask into libxenctrl. > > > > The flask library is small, and putting everything in libxenctrl make > > relying on flask functionalities in libxl easier. > > That doesn''t sound like a good reason to duplicate a library to me.Oh, ignore that, I''m being an idiot. :) Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel