prompt user start xencommons first if it is not running. Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com> diff -r be32d4fe1e8a -r 139ec4ec4067 tools/hotplug/Linux/init.d/xend --- a/tools/hotplug/Linux/init.d/xend Tue Jun 22 17:39:37 2010 +0800 +++ b/tools/hotplug/Linux/init.d/xend Tue Jun 22 18:04:59 2010 +0800 @@ -37,6 +37,11 @@ case "$1" in start) + service xencommons status >/dev/null 2>&1 + if [ $? -ne 0 ]; then + echo "xencommons should be started first." + exit 1 + fi mkdir -p /var/lock/subsys touch /var/lock/subsys/xend xend start _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2010-Jun-22 15:02 UTC
Re: [Xen-devel] [PATCH] xend: prompt user start xencommons
Yu Zhiguo writes ("[Xen-devel] [PATCH] xend: prompt user start xencommons"):> prompt user start xencommons first if it is not running.This isn''t portable. The "service" command is not available on all distributions. Perhaps a better check would be to see if xenstored is running, by calling xenstore-read -s / or some such ? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yu Zhiguo
2010-Jun-23 01:09 UTC
Re: [Xen-devel] [PATCH] xend: prompt user start xencommons
Hi Ian Ian Jackson wrote:> Yu Zhiguo writes ("[Xen-devel] [PATCH] xend: prompt user start xencommons"): >> prompt user start xencommons first if it is not running. > > This isn''t portable. The "service" command is not available on all > distributions. >Indeed.> Perhaps a better check would be to see if xenstored is running, by > calling xenstore-read -s / or some such ? >I''d like to check xenconsoled rather than xenstored is running or not to determine xencommons status, because xenconsoled can be killed when stop xencommons. ---------------------- prompt user start xencommons first if it is not running. Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com> diff -r a24dbfcbdf69 -r ee71d51a0437 tools/hotplug/Linux/init.d/xend --- a/tools/hotplug/Linux/init.d/xend Tue Jun 22 07:19:38 2010 +0100 +++ b/tools/hotplug/Linux/init.d/xend Wed Jun 23 17:11:34 2010 +0800 @@ -37,6 +37,10 @@ case "$1" in start) + if [ -z "`ps -C xenconsoled -o pid=`" ]; then + echo "xencommons should be started first." + exit 1 + fi mkdir -p /var/lock/subsys touch /var/lock/subsys/xend xend start _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel