Stefano Stabellini
2010-May-10 14:20 UTC
[Xen-devel] [PATCH 10/11] __setup_vector_irq: handle NULL chip_data
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
arch/x86/kernel/apic/io_apic.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 96f6bba..976646f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1287,6 +1287,8 @@ void __setup_vector_irq(int cpu)
/* Mark the inuse vectors */
for_each_irq_desc(irq, desc) {
cfg = desc->chip_data;
+ if (!cfg)
+ continue;
if (!cpumask_test_cpu(cpu, cfg->domain))
continue;
vector = cfg->vector;
--
1.5.4.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2010-May-10 15:35 UTC
Re: [Xen-devel] [PATCH 10/11] __setup_vector_irq: handle NULL chip_data
On Mon, May 10, 2010 at 03:20:46PM +0100, Stefano Stabellini wrote:> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > --- > arch/x86/kernel/apic/io_apic.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > index 96f6bba..976646f 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -1287,6 +1287,8 @@ void __setup_vector_irq(int cpu) > /* Mark the inuse vectors */ > for_each_irq_desc(irq, desc) { > cfg = desc->chip_data; > + if (!cfg) > + continue; > if (!cpumask_test_cpu(cpu, cfg->domain)) > continue; > vector = cfg->vector;Most curious. This looks be fixed upstream: http://lkml.org/lkml/2010/4/30/458 Do you know why the chip_data isn''t set? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2010-May-11 11:20 UTC
Re: [Xen-devel] [PATCH 10/11] __setup_vector_irq: handle NULL chip_data
On Mon, 10 May 2010, Konrad Rzeszutek Wilk wrote:> On Mon, May 10, 2010 at 03:20:46PM +0100, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > --- > > arch/x86/kernel/apic/io_apic.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > > index 96f6bba..976646f 100644 > > --- a/arch/x86/kernel/apic/io_apic.c > > +++ b/arch/x86/kernel/apic/io_apic.c > > @@ -1287,6 +1287,8 @@ void __setup_vector_irq(int cpu) > > /* Mark the inuse vectors */ > > for_each_irq_desc(irq, desc) { > > cfg = desc->chip_data; > > + if (!cfg) > > + continue; > > if (!cpumask_test_cpu(cpu, cfg->domain)) > > continue; > > vector = cfg->vector; > > Most curious. This looks be fixed upstream: > > http://lkml.org/lkml/2010/4/30/458 > > Do you know why the chip_data isn''t set? >I think is the VIRQ_TIMER handler that doesn''t have any chip_data: xen_setup_timer -> bind_virq_to_irqhandler -> find_unbound_irq -> dynamic_irq_init here chip_data is set to NULL. After that we call set_irq_chip_and_handler_name that set desc->chip but not desc->chip_data. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel