Guys When trying to move xen4.0 and libxl I found that libxl does not support vncpassword with in the device model. Was there are particular reason this feature is not implemented . To get our vms ported in to xen4 and to change our management stack to use libxl. I have done the following patch what do you guys think. Thank -- Gihan Munasinghe R&D Team Leader Flexiant Ltd. www.flexiant.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Guys When trying to move xen4.0 and libxl I found that libxl does not support vncpassword with in the device model. Was there are particular reason this feature is not implemented . To get our vms ported in to xen4 and to change our management stack to use libxl. I have done the following patch what do you guys think. Thanks Gihan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2010-May-06 16:02 UTC
Re: [Xen-devel] [PATCH] vncpassword support in libxl
On Thu, 6 May 2010, Gihan Munasinghe wrote:> > Guys > > When trying to move xen4.0 and libxl I found that libxl does not support > vncpassword with in the device model. > Was there are particular reason this feature is not implemented . To get > our vms ported in to xen4 and to change our management stack to use > libxl. I have done the following patch what do you guys think. > > Thanks > Gihan > >The indentation is often wrong and sometimes you are adding\removing blank lines for no reason. But apart from this small cosmetic issues the patch looks good. Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Gihan Munasinghe writes ("[Xen-devel] [PATCH] vncpassword support in libxl"):> When trying to move xen4.0 and libxl I found that libxl does not support > vncpassword with in the device model. > Was there are particular reason this feature is not implemented . To get > our vms ported in to xen4 and to change our management stack to use > libxl. I have done the following patch what do you guys think.It looks like a mostly reasonable patch, thanks. However you have made a couple of apparently accidental changes: - libxl_exec(null, logfile_w, logfile_w, + libxl_exec(null, logfile_w, logfile_w, ... - printf("Parsing config file %s\n", config_file); and so on. Could people please review your patches by eye - yes, read every line - before sending ? In this case, please resubmit with only the necessary changes. While you''re at it, you should probably ensure that you submit a patch which doesn''t introduce tabs. I don''t mind them but I know some people do. You may want (setq indent-tabs-mode nil) in Emacs. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in libxl"):> The indentation is often wrong and sometimes you are adding\removing > blank lines for no reason. > But apart from this small cosmetic issues the patch looks good.You missed that he removed this line: - printf("Parsing config file %s\n", config_file); This demonstrates why patches with spurious stuff in should be rejected - it''s too easy to miss a mistake when scanning past a lot of spurious changes. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Gihan Munasinghe
2010-May-06 16:10 UTC
Re: [Xen-devel] [PATCH] vncpassword support in libxl
Stefano Stabellini wrote:> On Thu, 6 May 2010, Gihan Munasinghe wrote: > >> Guys >> >> When trying to move xen4.0 and libxl I found that libxl does not support >> vncpassword with in the device model. >> Was there are particular reason this feature is not implemented . To get >> our vms ported in to xen4 and to change our management stack to use >> libxl. I have done the following patch what do you guys think. >> >> Thanks >> Gihan >> >> >> > > The indentation is often wrong and sometimes you are adding\removing > blank lines for no reason. > But apart from this small cosmetic issues the patch looks good. >Cool, I''ll do the cosmetic changes and resubmit the patch> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Gihan Munasinghe
2010-May-06 16:12 UTC
Re: [Xen-devel] [PATCH] vncpassword support in libxl
Ian Jackson wrote:> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in libxl"): > >> The indentation is often wrong and sometimes you are adding\removing >> blank lines for no reason. >> But apart from this small cosmetic issues the patch looks good. >> > > You missed that he removed this line: > > - printf("Parsing config file %s\n", config_file); > > This demonstrates why patches with spurious stuff in should be > rejected - it''s too easy to miss a mistake when scanning past a lot of > spurious changes. > > Ian. > > >Yes my mad will do the changes and resubmit again _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Gihan Munasinghe
2010-May-06 19:48 UTC
Re: [Xen-devel] [PATCH] vncpassword support in libxl
Ian Jackson wrote:> Gihan Munasinghe writes ("[Xen-devel] [PATCH] vncpassword support in libxl"): > >> When trying to move xen4.0 and libxl I found that libxl does not support >> vncpassword with in the device model. >> Was there are particular reason this feature is not implemented . To get >> our vms ported in to xen4 and to change our management stack to use >> libxl. I have done the following patch what do you guys think. >> > > It looks like a mostly reasonable patch, thanks. However you have > made a couple of apparently accidental changes: > > - libxl_exec(null, logfile_w, logfile_w, > + libxl_exec(null, logfile_w, logfile_w, > ... > - printf("Parsing config file %s\n", config_file); > > and so on. >Done> In this case, please resubmit with only the necessary changes. While > you''re at it, you should probably ensure that you submit a patch which > doesn''t introduce tabs. I don''t mind them but I know some people do. > You may want (setq indent-tabs-mode nil) in Emacs. >Made the code to use spaces as well New patch attached Thanks Gihan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Gihan Munasinghe writes ("Re: [Xen-devel] [PATCH] vncpassword support in libxl"):> New patch attachedGreat, thanks. Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 07/05/2010 11:02, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:> Gihan Munasinghe writes ("Re: [Xen-devel] [PATCH] vncpassword support in > libxl"): >> New patch attached > > Great, thanks. > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>Actually it was still full of hard tabs, but I fixed it before applying it. -- Keir> Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel