Xu, Dongxiao
2010-Apr-29 14:28 UTC
[Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into ''struct xen_netbk''.
Netback: Move global/static variables into struct xen_netbk. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2010-May-03 16:02 UTC
Re: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into ''struct xen_netbk''.
On Thu, Apr 29, 2010 at 10:28:18PM +0800, Xu, Dongxiao wrote:> Netback: Move global/static variables into struct xen_netbk.scripts/checkpatch.pl --strict ~/0001-Netback-Move-global-static-variables-into-struct-xe.patch WARNING: do not add new typedefs #24: FILE: drivers/xen/netback/common.h:231: +typedef unsigned int pending_ring_idx_t; CHECK: spinlock_t definition without comment #75: FILE: drivers/xen/netback/common.h:282: + spinlock_t net_schedule_list_lock; total: 0 errors, 1 warnings, 1 checks, 876 lines checked /home/konrad/0001-Netback-Move-global-static-variables-into-struct-xe.patch has style problems, please review. If any of these errors are false positives report them to> > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>> _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2010-May-03 16:05 UTC
Re: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into ''struct xen_netbk''.
On Thu, Apr 29, 2010 at 10:28:18PM +0800, Xu, Dongxiao wrote:> Netback: Move global/static variables into struct xen_netbk. > > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>Hmm.. git checkout jeremy/xen/next -b test-netbk-kthread -f Branch test-netbk-kthread set up to track remote branch refs/remotes/jeremy/xen/next. Switched to a new branch ''test-netbk-kthread'' [konrad@phenom linux]$ git reset --hard HEAD is now at 5403063 Merge remote branch ''stefano-pvhvm/2.6.32-pvhvm'' into xen/next [konrad@phenom linux]$ patch -p1 < ~/0001-Netback-Move-global-static-variables-into-struct-xe.patch patching file drivers/xen/netback/common.h patching file drivers/xen/netback/netback.c Hunk #1 succeeded at 48 (offset -1 lines). Hunk #2 succeeded at 64 (offset -1 lines). Hunk #3 succeeded at 90 (offset -1 lines). Hunk #4 FAILED at 105. Hunk #5 succeeded at 151 (offset -3 lines). Hunk #6 succeeded at 305 (offset -3 lines). Hunk #7 succeeded at 463 (offset -1 lines). Hunk #8 succeeded at 490 (offset -1 lines). Hunk #9 succeeded at 530 (offset -1 lines). Hunk #10 succeeded at 547 (offset -1 lines). Hunk #11 succeeded at 560 (offset -1 lines). .. snip.. 5 out of 44 hunks FAILED -- saving rejects to file drivers/xen/netback/netback.c.rej ... what branch are these patches against? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-May-04 00:48 UTC
RE: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into ''struct xen_netbk''.
I didn''t add the --strict option. I will change it accordingly. However for +typedef unsigned int pending_ring_idx_t; this typedef is moved from netback.c, and not the type. Thanks, Dongxiao Konrad Rzeszutek Wilk wrote:> On Thu, Apr 29, 2010 at 10:28:18PM +0800, Xu, Dongxiao wrote: >> Netback: Move global/static variables into struct xen_netbk. > > scripts/checkpatch.pl --strict > ~/0001-Netback-Move-global-static-variables-into-struct-xe.patch > WARNING: do not add new typedefs > #24: FILE: drivers/xen/netback/common.h:231: > +typedef unsigned int pending_ring_idx_t; > > CHECK: spinlock_t definition without comment > #75: FILE: drivers/xen/netback/common.h:282: > + spinlock_t net_schedule_list_lock; > > total: 0 errors, 1 warnings, 1 checks, 876 lines checked > > /home/konrad/0001-Netback-Move-global-static-variables-into-struct-xe.patch > has style problems, please review. If any of these errors > are false positives report them to > >> >> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> > >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-May-04 00:51 UTC
RE: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into ''struct xen_netbk''.
Konrad Rzeszutek Wilk wrote: The patchset is based on xen/master tree. I saw some merges in xen/master/netback is not contained in xen/next/netback, for example, the foreign_page_tracker. So I rebased my work on xen/master tree. Thanks, Dongxiao> On Thu, Apr 29, 2010 at 10:28:18PM +0800, Xu, Dongxiao wrote: >> Netback: Move global/static variables into struct xen_netbk. >> >> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> > > Hmm.. > > git checkout jeremy/xen/next -b test-netbk-kthread -f > Branch test-netbk-kthread set up to track remote branch > refs/remotes/jeremy/xen/next. > Switched to a new branch ''test-netbk-kthread'' > [konrad@phenom linux]$ git reset --hard > HEAD is now at 5403063 Merge remote branch > ''stefano-pvhvm/2.6.32-pvhvm'' into xen/next [konrad@phenom linux]$ > patch -p1 < > ~/0001-Netback-Move-global-static-variables-into-struct-xe.patch > patching file drivers/xen/netback/common.h > patching file drivers/xen/netback/netback.c > Hunk #1 succeeded at 48 (offset -1 lines). > Hunk #2 succeeded at 64 (offset -1 lines). > Hunk #3 succeeded at 90 (offset -1 lines). > Hunk #4 FAILED at 105. > Hunk #5 succeeded at 151 (offset -3 lines). > Hunk #6 succeeded at 305 (offset -3 lines). > Hunk #7 succeeded at 463 (offset -1 lines). > Hunk #8 succeeded at 490 (offset -1 lines). > Hunk #9 succeeded at 530 (offset -1 lines). > Hunk #10 succeeded at 547 (offset -1 lines). > Hunk #11 succeeded at 560 (offset -1 lines). > .. snip.. > 5 out of 44 hunks FAILED -- saving rejects to file > drivers/xen/netback/netback.c.rej > > ... what branch are these patches against?_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2010-May-04 02:03 UTC
Re: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into ''struct xen_netbk''.
On 05/03/2010 05:51 PM, Xu, Dongxiao wrote:> Konrad Rzeszutek Wilk wrote: > The patchset is based on xen/master tree. > I saw some merges in xen/master/netback is not contained in > xen/next/netback, for example, the foreign_page_tracker. > > So I rebased my work on xen/master tree. >Please base on (ideally) xen/dom0/netback, or xen/next. The foreign page tracker stuff is part of netchannel2, and not (yet?) included in the 2.6.32+ kernels. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel