Xu, Dongxiao
2010-Apr-22 02:37 UTC
[Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
Add debug-key ''D'' to dump EPT p2m table. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Apr-22 07:18 UTC
Re: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
>>> "Xu, Dongxiao" 04/22/10 4:42 AM >>>The use of map_domain_page() here is lacking a respective unmap_domain_page() on all possible paths. Further, assuming the amount of information printed may be huge, there ought to be calls to process_pending_softirqs() to keep time management from getting screwed. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Apr-22 09:00 UTC
Re: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
At 08:18 +0100 on 22 Apr (1271924329), Jan Beulich wrote:> >>> "Xu, Dongxiao" 04/22/10 4:42 AM >>> > The use of map_domain_page() here is lacking a respective > unmap_domain_page() on all possible paths. > > Further, assuming the amount of information printed may be > huge, there ought to be calls to process_pending_softirqs() > to keep time management from getting screwed.Also, for the same reason, I think maybe it shouldn''t be marked as a ''diagnostic'' keyhandler (even though it really is diagnostic, it can very easily fill the dmesg buffers). Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-Apr-22 09:24 UTC
RE: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
Hi Tim and Jan, I modified the patch according to your comments. Please help to review. Thanks, Dongxiao Tim Deegan wrote:> At 08:18 +0100 on 22 Apr (1271924329), Jan Beulich wrote: >>>>> "Xu, Dongxiao" 04/22/10 4:42 AM >>> >> The use of map_domain_page() here is lacking a respective >> unmap_domain_page() on all possible paths. >> >> Further, assuming the amount of information printed may be >> huge, there ought to be calls to process_pending_softirqs() >> to keep time management from getting screwed. > > Also, for the same reason, I think maybe it shouldn''t be marked as a > ''diagnostic'' keyhandler (even though it really is diagnostic, it can > very easily fill the dmesg buffers). > > Cheers, > > Tim._______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2010-Apr-22 09:44 UTC
Re: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
Hi, At 10:24 +0100 on 22 Apr (1271931845), Xu, Dongxiao wrote:> Hi Tim and Jan, > > I modified the patch according to your comments. > Please help to review.Looks OK. It might be nice to print the POD entries too, but I''m happy with this version. Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Apr-22 11:15 UTC
RE: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
>>> "Xu, Dongxiao" <dongxiao.xu@intel.com> 22.04.10 11:24 >>> >I modified the patch according to your comments. >Please help to review.Is process_pending_softirqs() once per domain really enough? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-Apr-23 03:06 UTC
RE: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
Hi Tim and Jan, This version of patch adds: 1. pod entry dump. 2. process_pending_softirqs() is called after every 100 printk records. Please help to review. Thanks, Dongxiao Jan Beulich wrote:>>>> "Xu, Dongxiao" <dongxiao.xu@intel.com> 22.04.10 11:24 >>> >> I modified the patch according to your comments. >> Please help to review. > > Is process_pending_softirqs() once per domain really enough? > > Jan_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Apr-23 06:57 UTC
RE: [Xen-devel][PATCH] VMX: Add debug-key ''D'' to dump EPT p2m table
Looks okay to me now. Thanks! Jan>>> "Xu, Dongxiao" <dongxiao.xu@intel.com> 23.04.10 05:06 >>>Hi Tim and Jan, This version of patch adds: 1. pod entry dump. 2. process_pending_softirqs() is called after every 100 printk records. Please help to review. Thanks, Dongxiao Jan Beulich wrote:>>>> "Xu, Dongxiao" <dongxiao.xu@intel.com> 22.04.10 11:24 >>> >> I modified the patch according to your comments. >> Please help to review. > > Is process_pending_softirqs() once per domain really enough? > > Jan_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel