Jan Beulich
2010-Apr-16 10:13 UTC
[Xen-devel] [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix
Perhaps this should even be further generalized (e.g. to remove any "[!/]*:" pattern prefixes) to be more forward compatible? Signed-off-by: Jan Beulich <jbeulich@novell.com> --- a/tools/hotplug/Linux/blktap 2010-02-16 18:06:25.000000000 +0100 +++ b/tools/hotplug/Linux/blktap 2010-04-16 11:46:29.000000000 +0200 @@ -59,6 +59,7 @@ if [ -n "$t" ] then p=$(xenstore_read "$XENBUS_PATH/params") + p=${p#tapdisk:} # if we have a '':'', chew from head including : if echo $p | grep -q \: then _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jim Fehlig
2010-Apr-16 20:51 UTC
Re: [Xen-devel] [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix
Jan Beulich wrote:> Perhaps this should even be further generalized (e.g. to remove any > "[!/]*:" pattern prefixes) to be more forward compatible? >Right. Need to handle the ''ioemu'' subtype as well. How about just stripping of everything before the leading ''/''? E.g. like the attached patch? Regards, Jim _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Apr-19 07:38 UTC
Re: [Xen-devel] [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix
>>> Jim Fehlig <jfehlig@novell.com> 16.04.10 22:51 >>> >Jan Beulich wrote: >> Perhaps this should even be further generalized (e.g. to remove any >> "[!/]*:" pattern prefixes) to be more forward compatible? >> > >Right. Need to handle the ''ioemu'' subtype as well. How about just >stripping of everything before the leading ''/''? E.g. like the attached >patch?Wouldn''t that become wrong when remote locations are acceptable here (not sure if they aren''t already), i.e. server:/path/file? If that is not expected to ever have a meaning and if relative paths aren''t permitted here, then yes, that would of course be the best solution. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jim Fehlig
2010-Apr-20 03:02 UTC
Re: [Xen-devel] [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix
Jan Beulich wrote:>>>> Jim Fehlig <jfehlig@novell.com> 16.04.10 22:51 >>> >>>> >> Jan Beulich wrote: >> >>> Perhaps this should even be further generalized (e.g. to remove any >>> "[!/]*:" pattern prefixes) to be more forward compatible? >>> >>> >> Right. Need to handle the ''ioemu'' subtype as well. How about just >> stripping of everything before the leading ''/''? E.g. like the attached >> patch? >> > > Wouldn''t that become wrong when remote locations are acceptable > here (not sure if they aren''t already), i.e. server:/path/file?IMO, remote locations should be handled by another tap driver optimized for the remote file protocol, similar to the nbd, curl, etc. block backends in qemu.> If that > is not expected to ever have a meaning and if relative paths aren''t > permitted here, then yes, that would of course be the best solution. >The tools currently don''t cope with relative paths in disk specification. Jim _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel