Andre Przywara
2010-Apr-15 14:05 UTC
[Xen-devel] [PATCH] xend: fix best NUMA node allocation
Hi, since we moved several NUMA info fields from physinfo into separate functions/structures, we must adapt the node picking algorithm, too. Currently xm create complains about undefined hash values. The patch uses the new Python xc binding to get the information and create a reverse mapping for node_to_cpu, since we now only have a cpu_to_node field. Signed-off-by: Andre Przywara <andre.przywara@amd.com> -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448-3567-12 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Bruce Edge
2010-May-28 16:25 UTC
Re: [Xen-devel] [PATCH] xend: fix best NUMA node allocation
Even with this patch applied I''m still seeing the cpu_to_node key errors in the xen-unstable build: [2010-05-28 02:14:42 3313] ERROR (xmlrpclib2:178) Internal error handling xend.domain.create Traceback (most recent call last): File "/usr/local/lib/python2.6/dist-packages/xen/util/xmlrpclib2.py", line 131, in _marshaled_dispatch response = self._dispatch(method, params) File "/usr/lib/python2.6/SimpleXMLRPCServer.py", line 418, in _dispatch return func(*params) File "/usr/local/lib/python2.6/dist-packages/xen/xend/server/XMLRPCServer.py", line 80, in domain_create info = XendDomain.instance().domain_create(config) File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomain.py", line 982, in domain_create dominfo = XendDomainInfo.create(config) File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 106, in create vm.start() File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 470, in start XendTask.log_progress(0, 30, self._constructDomain) File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendTask.py", line 209, in log_progress retval = func(*args, **kwds) File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 2530, in _constructDomain balloon.free(16*1024, self) # 16MB should be plenty File "/usr/local/lib/python2.6/dist-packages/xen/xend/balloon.py", line 187, in free nodenum = xc.numainfo()[''cpu_to_node''][cpu] KeyError: ''cpu_to_node'' xen_major : 4 xen_minor : 1 xen_extra : -unstable xen_caps : xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 hvm-3.0-x86_32p hvm-3.0-x86_64 xen_scheduler : credit xen_pagesize : 4096 platform_params : virt_start=0xffff800000000000 xen_changeset : Sat May 22 06:36:41 2010 +0100 21446:93410e5e4ad8 xen_commandline : dummy=dummy console=com1 115200,8n1 dom0_mem=512M dom0_max_vcpus=1 dom0_vcpus_pin=true iommu=1,passthrough,no-intremap loglvl=all loglvl_guest=all loglevl=10 debug acpi=force apic=on apic_verbosity=verbose cc_compiler : gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4) cc_compile_by : bedge cc_compile_domain : cc_compile_date : Tue May 25 14:51:02 PDT 2010 xend_config_format : 4 -Bruce On Thu, Apr 15, 2010 at 7:05 AM, Andre Przywara <andre.przywara@amd.com> wrote:> > Hi, > > since we moved several NUMA info fields from physinfo into separate functions/structures, we must adapt the node picking algorithm, too. > Currently xm create complains about undefined hash values. > The patch uses the new Python xc binding to get the information and create a reverse mapping for node_to_cpu, since we now only have a cpu_to_node field. > > Signed-off-by: Andre Przywara <andre.przywara@amd.com> > > -- > Andre Przywara > AMD-Operating System Research Center (OSRC), Dresden, Germany > Tel: +49 351 448-3567-12 > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Jun-01 05:56 UTC
Re: [Xen-devel] [PATCH] xend: fix best NUMA node allocation
On 28/05/2010 17:25, "Bruce Edge" <bruce.edge@gmail.com> wrote:> Even with this patch applied I''m still seeing the cpu_to_node key > errors in the xen-unstable build:This should be fixed by xen-unstable:21494. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel