Hi! Attached patch merges ptp allocation in p2m. Signed-off-by: Christoph Egger <Christop.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, At 10:25 +0100 on 13 Apr (1271154340), Christoph Egger wrote:> Attached patch merges ptp allocation in p2m. > > Signed-off-by: Christoph Egger <Christop.Egger@amd.com>> diff -r 105fdf064d27 xen/arch/x86/mm/hap/private.h > --- a/xen/arch/x86/mm/hap/private.h Tue Apr 13 10:35:24 2010 +0200 > +++ b/xen/arch/x86/mm/hap/private.h Tue Apr 13 10:59:55 2010 +0200 > @@ -30,5 +30,6 @@ unsigned long hap_gva_to_gfn_3_levels(st > unsigned long hap_gva_to_gfn_4_levels(struct vcpu *v, unsigned long gva, > uint32_t *pfec); > > +struct page_info *p2m_alloc_ptp(struct domain *d, unsigned long type);Why is this declared in hap/private.h when it''s not a hap function? Maybe asm-x86/p2m.h would be a better place. Otherwise, Ack. Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tuesday 13 April 2010 12:22:21 Tim Deegan wrote:> Hi, > > At 10:25 +0100 on 13 Apr (1271154340), Christoph Egger wrote: > > Attached patch merges ptp allocation in p2m. > > > > Signed-off-by: Christoph Egger <Christop.Egger@amd.com> > > > > diff -r 105fdf064d27 xen/arch/x86/mm/hap/private.h > > --- a/xen/arch/x86/mm/hap/private.h Tue Apr 13 10:35:24 2010 +0200 > > +++ b/xen/arch/x86/mm/hap/private.h Tue Apr 13 10:59:55 2010 +0200 > > @@ -30,5 +30,6 @@ unsigned long hap_gva_to_gfn_3_levels(st > > unsigned long hap_gva_to_gfn_4_levels(struct vcpu *v, unsigned long gva, > > uint32_t *pfec); > > > > +struct page_info *p2m_alloc_ptp(struct domain *d, unsigned long type); > > Why is this declared in hap/private.h when it''s not a hap function? > Maybe asm-x86/p2m.h would be a better place.Ok, I''m fine with this change. Keir: Do you want me to resend the diff or will you do that right before applying the patch?> > Otherwise, Ack.Thanks.> Tim.Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel