Christoph Egger
2010-Apr-01 08:30 UTC
[Xen-devel] [PATCH] xen: move viridian defines to header
Hi! Attached patch moves viridian defines into viridian header. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Apr-01 08:50 UTC
Re: [Xen-devel] [PATCH] xen: move viridian defines to header
On 01/04/2010 09:30, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi! > > Attached patch moves viridian defines into viridian header. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>I don''t consider this a clean up by itself. It''s nicer to define things in a .c file if they are only sued in that .c file. Also moving the MSRs out but not other viridian-architectural defines like the MSR flag definitions and hypercall status codes seems inconsistent. I would consider this as part of a patch series where later patches that I actually care about make use of this change. On its own, it gets a nack. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel