Jan Beulich
2010-Mar-23 16:56 UTC
[Xen-devel] [PATCH] VT-d: avoid faulting in print_iommu_regs()
In c/s 21027 I overlooked that using this function when bad table data
was found requires the function to also do some range checking.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- 2010-03-22.orig/xen/drivers/passthrough/vtd/utils.c 2010-03-17
22:19:25.000000000 +0100
+++ 2010-03-22/xen/drivers/passthrough/vtd/utils.c 2010-03-23 17:52:20.000000000
+0100
@@ -67,10 +67,13 @@ void print_iommu_regs(struct acpi_drhd_u
printk(" CAP = %"PRIx64"\n", cap =
dmar_readq(iommu->reg, DMAR_CAP_REG));
printk(" n_fault_reg = %"PRIx64"\n",
cap_num_fault_regs(cap));
printk(" fault_recording_offset = %"PRIx64"\n",
cap_fault_reg_offset(cap));
- printk(" fault_recording_reg_l = %"PRIx64"\n",
- dmar_readq(iommu->reg, cap_fault_reg_offset(cap)));
- printk(" fault_recording_reg_h = %"PRIx64"\n",
- dmar_readq(iommu->reg, cap_fault_reg_offset(cap) + 8));
+ if ( cap_fault_reg_offset(cap) < PAGE_SIZE )
+ {
+ printk(" fault_recording_reg_l = %"PRIx64"\n",
+ dmar_readq(iommu->reg, cap_fault_reg_offset(cap)));
+ printk(" fault_recording_reg_h = %"PRIx64"\n",
+ dmar_readq(iommu->reg, cap_fault_reg_offset(cap) + 8));
+ }
printk(" ECAP = %"PRIx64"\n", dmar_readq(iommu->reg,
DMAR_ECAP_REG));
printk(" GCMD = %x\n", dmar_readl(iommu->reg, DMAR_GCMD_REG));
printk(" GSTS = %x\n", dmar_readl(iommu->reg, DMAR_GSTS_REG));
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel