Yu Zhiguo
2009-Dec-10 07:36 UTC
[Xen-devel] [PATCH] mini-os: Fix memory leaks in xs_read() and xs_write()
xenbus_read() and xenbus_write() will allocate memory for error message if any error occurs, this memory should be freed. Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com> diff --git a/extras/mini-os/lib/xs.c b/extras/mini-os/lib/xs.c --- a/extras/mini-os/lib/xs.c +++ b/extras/mini-os/lib/xs.c @@ -49,6 +49,7 @@ msg = xenbus_read(t, path, &value); if (msg) { printk("xs_read(%s): %s\n", path, msg); + free(msg); return NULL; } @@ -69,6 +70,7 @@ msg = xenbus_write(t, path, value); if (msg) { printk("xs_write(%s): %s\n", path, msg); + free(msg); return false; } return true; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2009-Dec-10 13:43 UTC
Re: [Xen-devel] [PATCH] mini-os: Fix memory leaks in xs_read() and xs_write()
On Thu, 10 Dec 2009, Yu Zhiguo wrote:> > xenbus_read() and xenbus_write() will allocate memory > for error message if any error occurs, this memory > should be freed. > > Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com>Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel