ian.campbell@citrix.com
2009-Dec-03 21:56 UTC
[Xen-devel] Rename backend modules to be less generic.
netbk, blkbk and pciback are all rather generic, rename then along the lines of xen-*back. Split up into several patches since each backend seem to have its own branch. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
ian.campbell@citrix.com
2009-Dec-03 21:56 UTC
[Xen-devel] [PATCH 1/3] xen: rename blkbk module xen-blkback.
From: Ian Campbell <ijc@hellion.org.uk> blkbk is rather generic for a modular distro style kernel. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Cc: Jeremy Fitzhardinge <jeremy@goop.org> --- drivers/xen/blkback/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/blkback/Makefile b/drivers/xen/blkback/Makefile index 8bab63d..f1ae1ff 100644 --- a/drivers/xen/blkback/Makefile +++ b/drivers/xen/blkback/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_XEN_BLKDEV_BACKEND) := blkbk.o +obj-$(CONFIG_XEN_BLKDEV_BACKEND) := xen-blkback.o -blkbk-y := blkback.o xenbus.o interface.o vbd.o +xen-blkback-y := blkback.o xenbus.o interface.o vbd.o -- 1.6.5.3 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
ian.campbell@citrix.com
2009-Dec-03 21:56 UTC
[Xen-devel] [PATCH 2/3] xen: rename netbk module xen-netback.
From: Ian Campbell <ijc@hellion.org.uk> netbk is rather generic for a modular distro style kernel. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Cc: Jeremy Fitzhardinge <jeremy@goop.org> --- drivers/xen/netback/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/netback/Makefile b/drivers/xen/netback/Makefile index a01a1a3..e346e81 100644 --- a/drivers/xen/netback/Makefile +++ b/drivers/xen/netback/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_XEN_NETDEV_BACKEND) := netbk.o +obj-$(CONFIG_XEN_NETDEV_BACKEND) := xen-netback.o -netbk-y := netback.o xenbus.o interface.o +xen-netback-y := netback.o xenbus.o interface.o -- 1.6.5.3 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
ian.campbell@citrix.com
2009-Dec-03 21:56 UTC
[Xen-devel] [PATCH 3/3] xen: rename pciback module to xen-pciback.
From: Ian Campbell <ijc@hellion.org.uk> pciback is rather generic for a modular distro style kernel. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Cc: Jeremy Fitzhardinge <jeremy@goop.org> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- drivers/xen/pciback/Makefile | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/xen/pciback/Makefile b/drivers/xen/pciback/Makefile index 106dae7..38bc123 100644 --- a/drivers/xen/pciback/Makefile +++ b/drivers/xen/pciback/Makefile @@ -1,16 +1,16 @@ -obj-$(CONFIG_XEN_PCIDEV_BACKEND) += pciback.o +obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o -pciback-y := pci_stub.o pciback_ops.o xenbus.o -pciback-y += conf_space.o conf_space_header.o \ - conf_space_capability.o \ - conf_space_capability_vpd.o \ - conf_space_capability_pm.o \ - conf_space_quirks.o -pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o +xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o +xen-pciback-y += conf_space.o conf_space_header.o \ + conf_space_capability.o \ + conf_space_capability_vpd.o \ + conf_space_capability_pm.o \ + conf_space_quirks.o +xen-pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o ifeq ($(CONFIG_XEN_PCIDEV_BE_DEBUG),y) EXTRA_CFLAGS += -DDEBUG -- 1.6.5.3 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2009-Dec-03 22:02 UTC
[Xen-devel] Re: [PATCH 3/3] xen: rename pciback module to xen-pciback.
On Thu, Dec 03, 2009 at 09:56:20PM +0000, ian.campbell@citrix.com wrote:> pciback is rather generic for a modular distro style kernel.Do you have a patch for Xen python stack to check ownership of PCI devices to also be ''xen-pciback''?> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > Cc: Jeremy Fitzhardinge <jeremy@goop.org> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>> --- > drivers/xen/pciback/Makefile | 24 ++++++++++++------------ > 1 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/xen/pciback/Makefile b/drivers/xen/pciback/Makefile > index 106dae7..38bc123 100644 > --- a/drivers/xen/pciback/Makefile > +++ b/drivers/xen/pciback/Makefile > @@ -1,16 +1,16 @@ > -obj-$(CONFIG_XEN_PCIDEV_BACKEND) += pciback.o > +obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o > > -pciback-y := pci_stub.o pciback_ops.o xenbus.o > -pciback-y += conf_space.o conf_space_header.o \ > - conf_space_capability.o \ > - conf_space_capability_vpd.o \ > - conf_space_capability_pm.o \ > - conf_space_quirks.o > -pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o > +xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o > +xen-pciback-y += conf_space.o conf_space_header.o \ > + conf_space_capability.o \ > + conf_space_capability_vpd.o \ > + conf_space_capability_pm.o \ > + conf_space_quirks.o > +xen-pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o > > ifeq ($(CONFIG_XEN_PCIDEV_BE_DEBUG),y) > EXTRA_CFLAGS += -DDEBUG > -- > 1.6.5.3 >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-Dec-03 22:08 UTC
[Xen-devel] Re: [PATCH 3/3] xen: rename pciback module to xen-pciback.
On 12/03/09 14:02, Konrad Rzeszutek Wilk wrote:> On Thu, Dec 03, 2009 at 09:56:20PM +0000, ian.campbell@citrix.com wrote: > >> pciback is rather generic for a modular distro style kernel. >> > Do you have a patch for Xen python stack to check ownership of > PCI devices to also be ''xen-pciback''? >Is the module name the same as the driver name? J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2009-Dec-03 22:14 UTC
[Xen-devel] Re: [PATCH 3/3] xen: rename pciback module to xen-pciback.
On Thu, 2009-12-03 at 22:02 +0000, Konrad Rzeszutek Wilk wrote:> On Thu, Dec 03, 2009 at 09:56:20PM +0000, ian.campbell@citrix.com wrote: > > pciback is rather generic for a modular distro style kernel. > > Do you have a patch for Xen python stack to check ownership of > PCI devices to also be ''xen-pciback''?Ah, it never even occurred to me that such a thing would be necessary. I think (but I should check) that the sysfs name will remain pciback since it comes from the .name in struct xenbus_driver. I''m not sure if it is confusing or not to have the module name be different to the driver name nor how common it is. Ian.> > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > Cc: Jeremy Fitzhardinge <jeremy@goop.org> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > --- > > drivers/xen/pciback/Makefile | 24 ++++++++++++------------ > > 1 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/xen/pciback/Makefile b/drivers/xen/pciback/Makefile > > index 106dae7..38bc123 100644 > > --- a/drivers/xen/pciback/Makefile > > +++ b/drivers/xen/pciback/Makefile > > @@ -1,16 +1,16 @@ > > -obj-$(CONFIG_XEN_PCIDEV_BACKEND) += pciback.o > > +obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o > > > > -pciback-y := pci_stub.o pciback_ops.o xenbus.o > > -pciback-y += conf_space.o conf_space_header.o \ > > - conf_space_capability.o \ > > - conf_space_capability_vpd.o \ > > - conf_space_capability_pm.o \ > > - conf_space_quirks.o > > -pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o > > +xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o > > +xen-pciback-y += conf_space.o conf_space_header.o \ > > + conf_space_capability.o \ > > + conf_space_capability_vpd.o \ > > + conf_space_capability_pm.o \ > > + conf_space_quirks.o > > +xen-pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o > > > > ifeq ($(CONFIG_XEN_PCIDEV_BE_DEBUG),y) > > EXTRA_CFLAGS += -DDEBUG > > -- > > 1.6.5.3 > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-Dec-03 22:18 UTC
[Xen-devel] Re: [PATCH 3/3] xen: rename pciback module to xen-pciback.
On 12/03/09 14:14, Ian Campbell wrote:> Ah, it never even occurred to me that such a thing would be necessary. > > I think (but I should check) that the sysfs name will remain pciback > since it comes from the .name in struct xenbus_driver. I''m not sure if > it is confusing or not to have the module name be different to the > driver name nor how common it is. >The driver name is a bit of an ABI for hotplug, etc, anyway, so having the Xen tools depend on that name isn''t very odd. And while it is best if the module matches the driver name, it''s not uncommon for it to mismatch - and we''ve been doing it for ages anyway (xen_netfront is called "vif" and aliased "xen:vif" and "xennet"). J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2009-Dec-03 22:20 UTC
[Xen-devel] Re: [PATCH 3/3] xen: rename pciback module to xen-pciback.
On Thu, Dec 03, 2009 at 02:08:52PM -0800, Jeremy Fitzhardinge wrote:> On 12/03/09 14:02, Konrad Rzeszutek Wilk wrote: >> On Thu, Dec 03, 2009 at 09:56:20PM +0000, ian.campbell@citrix.com wrote: >> >>> pciback is rather generic for a modular distro style kernel. >>> >> Do you have a patch for Xen python stack to check ownership of >> PCI devices to also be ''xen-pciback''? >> > > Is the module name the same as the driver name?Not with this patch. The driver name is ''pciback'' but the module name will be ''xen-pciback''. I am not sure how that is going to resolve in SysFS - hopefully it will remain ''pciback'' for the pertient directories. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel