Hi! Attached patch makes libxl build on NetBSD. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: build
fix"):> Attached patch makes libxl build on NetBSD.
The patch is fine, although I don''t generally approve of comments like
the one you''ve included:
+#include <signal.h> /* for SIGKILL */
I would just say:
+#include <signal.h>
and you can mention SIGKILL in the commit message.
There is an argument that all of these headers should be included in
one place by libxl_internal.h.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel