The latest unstable tree has few bugs related to string format (on some 64bit numbers). This makes compilation with new gcc (like in gcc 4.3.3) fail. The enclosed patch fixes the problems. Signed-off-by: Jun Koi <junkoi2004@gmail.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Jun-24 10:13 UTC
Re: [Xen-devel] [PATCH] fix string format bugs in -unstable
At least fix with the correct specifier. Should be PRIu64. I applied a correct fix as c/s 19826. -- Keir On 24/06/2009 04:15, "Jun Koi" <junkoi2004@gmail.com> wrote:> The latest unstable tree has few bugs related to string format (on > some 64bit numbers). This makes compilation with new gcc (like in gcc > 4.3.3) fail. > > The enclosed patch fixes the problems. > > Signed-off-by: Jun Koi <junkoi2004@gmail.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, Jun 24, 2009 at 7:13 PM, Keir Fraser<keir.fraser@eu.citrix.com> wrote:> At least fix with the correct specifier. Should be PRIu64. I applied a > correct fix as c/s 19826.The fix is not yet pushed to tree? I tried to pull, but see no change. Thanks, J> On 24/06/2009 04:15, "Jun Koi" <junkoi2004@gmail.com> wrote: > >> The latest unstable tree has few bugs related to string format (on >> some 64bit numbers). This makes compilation with new gcc (like in gcc >> 4.3.3) fail. >> >> The enclosed patch fixes the problems. >> >> Signed-off-by: Jun Koi <junkoi2004@gmail.com> > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Jun-24 10:53 UTC
Re: [Xen-devel] [PATCH] fix string format bugs in -unstable
On 24/06/2009 11:25, "Jun Koi" <junkoi2004@gmail.com> wrote:> On Wed, Jun 24, 2009 at 7:13 PM, Keir Fraser<keir.fraser@eu.citrix.com> wrote: >> At least fix with the correct specifier. Should be PRIu64. I applied a >> correct fix as c/s 19826. > > The fix is not yet pushed to tree? I tried to pull, but see no change.It''s in the staging tree. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, Jun 24, 2009 at 7:53 PM, Keir Fraser<keir.fraser@eu.citrix.com> wrote:> On 24/06/2009 11:25, "Jun Koi" <junkoi2004@gmail.com> wrote: > >> On Wed, Jun 24, 2009 at 7:13 PM, Keir Fraser<keir.fraser@eu.citrix.com> wrote: >>> At least fix with the correct specifier. Should be PRIu64. I applied a >>> correct fix as c/s 19826. >> >> The fix is not yet pushed to tree? I tried to pull, but see no change. > > It''s in the staging tree.BTW, what is the purpose of the -staging trees?? Thanks, J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Jun-24 14:06 UTC
Re: [Xen-devel] [PATCH] fix string format bugs in -unstable
On 24/06/2009 14:45, "Jun Koi" <junkoi2004@gmail.com> wrote:>>> On Wed, Jun 24, 2009 at 7:13 PM, Keir Fraser<keir.fraser@eu.citrix.com> >>> wrote: >>>> At least fix with the correct specifier. Should be PRIu64. I applied a >>>> correct fix as c/s 19826. >>> >>> The fix is not yet pushed to tree? I tried to pull, but see no change. >> >> It''s in the staging tree. > > BTW, what is the purpose of the -staging trees??Early access to changesets before they pass automated tests (when the automated tests are working, that is). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Jun-24 15:12 UTC
Re: [Xen-devel] [PATCH] fix string format bugs in -unstable
Jun Koi writes ("Re: [Xen-devel] [PATCH] fix string format bugs in -unstable"):> BTW, what is the purpose of the -staging trees??We commit patches directly to the staging tree (well, actually an internal tree that''s mirrored rapidly to staging). They are then automatically tested, and if the tests pass, the changesets that passed the tests are pushed through to the main tree. That means that the community at large has something stable to work with. The -staging trees are there so you can have the latest bleeding edge, even if it''s broken. ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Jul-13 23:02 UTC
Re: [Xen-devel] [PATCH] fix string format bugs in -unstable
On Wed, Jun 24, 2009 at 04:12:43PM +0100, Ian Jackson wrote:> Jun Koi writes ("Re: [Xen-devel] [PATCH] fix string format bugs in -unstable"): > > BTW, what is the purpose of the -staging trees?? > > We commit patches directly to the staging tree (well, actually an > internal tree that''s mirrored rapidly to staging). They are then > automatically tested, and if the tests pass, the changesets that > passed the tests are pushed through to the main tree. > > That means that the community at large has something stable to work > with. The -staging trees are there so you can have the latest > bleeding edge, even if it''s broken.What are the nature of these tests? Is it possible for people to extend the tests as they fix / extend the code? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel